Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New compound button colors feel very bright and aggressive in the dark theme. #27006

Closed
MTRNord opened this issue Feb 13, 2024 · 2 comments
Closed
Assignees
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Compound

Comments

@MTRNord
Copy link
Contributor

MTRNord commented Feb 13, 2024

Steps to reproduce

  1. Open the settings for example

Outcome

What did you expect?

A theme that is not disturbing to look at for long times

What happened instead?

image

The buttons have very harsh contrasts, making it hard for me to read and look at them for extended amounts of time (aka anything more than 30s).

Operating system

Fedora Silverblue 39

Browser information

Firefox 121.0.1 (64-bit)

URL for webapp

develop.element.io

Application version

Version von Element: 92c8310-react-ed5ef023b24b-js-d03db1740586 Krypto-Version: Rust SDK 0.7.0 (fac36bc), Vodozemac 0.5.1

Homeserver

matrix.midnightthoughts.space

Will you send logs?

No

@robintown
Copy link
Member

Because these parts of the interface weren't designed with the new Compound colors in mind, we're definitely overapplying those bright, punchy primary buttons here. This situation will get better as we redesign more of the application to use Compound buttons in a way that matches their visual weight, but I think changing some of these buttons to secondary ahead of a redesign is also reasonable.

@robintown robintown self-assigned this Feb 14, 2024
@MidhunSureshR MidhunSureshR added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-Compound labels Feb 14, 2024
@robintown
Copy link
Member

On the second iteration of this change (matrix-org/matrix-react-sdk#12299) I changed some of these buttons to secondary where appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Compound
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants