E2E: Key Backup: Recovery UI confusing (key vs. passphrase)

[jryans]

When attempting to use key recovery from a new device, I saw the following screens:

The status above really doesn't make it clear that I actually have keys backed up and I can still access them. (Extracted status message to #9446.) "Use key backup" feels like it's telling me I haven't set it up at all. "Restore from key backup" would be a better string to use there. (Extracted button text to #9438.)

Looking at the Advanced section:

The Advanced section is the only bit that suggests I actually do have a working backup. The "basic" / non-advanced view should always suggest a backup exists if there is one.

When I click "Use key backup", I see:

To be honest, even after working on Riot every day, I find it hard to remember which one is the "key" and which is the "passphrase". I tried my recovery key here, but that failed, so eventually I clicked the link to change to that dialog:

This did succeed, but the path to reach it as I've described here was quite confusing.

[jryans]

This still needs some big picture thinking on how to reduce confusion, but I think a small tweak that would simplify the current model in my mind at least is if we only use "recovery" for one of the two:

• "recovery passphrase" becomes "key backup passphrase" or similar
• "recovery key" remains as-is

[nadonomy]

Agree all of this needs work, but just labelling confidence in low in the right solution as:

1. We'll want to change this kind of nomenclature holistically
2. We'll want to test any changes with users
3. It'll happen as part of a concerted cross-platform effort by the crypto & auth teams