Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read receipt avatars & names sometimes fail to show until the room is reopened #2176

Closed
surakin opened this issue Jan 5, 2024 · 2 comments · Fixed by #2194
Closed

Read receipt avatars & names sometimes fail to show until the room is reopened #2176

surakin opened this issue Jan 5, 2024 · 2 comments · Fixed by #2194
Assignees
@jmartinesp
Labels
A-Read-Receipt O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@surakin
Copy link
Contributor

surakin commented Jan 5, 2024

Steps to reproduce

  1. Start Element X, open any room
  2. Notice how some read receipt avatars are missing and you just see the initial
  3. Go back and open the same room again
  4. Avatars show up.

(It doesn't happen 100% of the times)

Outcome

What did you expect?

Avatars should always show up (eventually)

What happened instead?

They don't show up until the room is reopened

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

Yes
@surakin surakin added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jan 5, 2024
@ara4n ara4n mentioned this issue Jan 6, 2024
Closed
@jmartinesp jmartinesp added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Read-Receipt labels Jan 8, 2024
@jmartinesp
Copy link
Member

Note: this seems to affect iOS too, so it's either a coincidence or it's related to how we get this info from Rust.

@jmartinesp jmartinesp self-assigned this Jan 8, 2024
@jmartinesp
Copy link
Member

Apparently, it's a coincidence. It was our caching working against us. As the saying goes:

There's only 2 hard things on computer science: cache invalidation, naming things, and off-by-one errors

@jmartinesp jmartinesp mentioned this issue Jan 8, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartinesp jmartinesp

Labels
A-Read-Receipt O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update timeline items read receipts when the room members are loaded element-hq/element-x-android
2 participants
@jmartinesp @surakin