Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating several rooms results in a room preview being displayed #3183

Closed
jmartinesp opened this issue Jul 12, 2024 · 8 comments
Closed

Creating several rooms results in a room preview being displayed #3183

jmartinesp opened this issue Jul 12, 2024 · 8 comments
Assignees
Labels
A-SSS Regression or bug observed when using Simplified Sliding Sync T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@jmartinesp
Copy link
Member

Steps to reproduce

  1. From the room list, create a new room, you should be taken into it immediately.
  2. Go back to the room list.
  3. Now create another room.
  4. Instead of opening the new room, you'll see the room preview of the just created room instead.
  5. If you go back to the room list, you won't be able to find the room in the list either until the app is restarted.

Outcome

What did you expect?

The create room flow to be consistent.

What happened instead?

After the first room is created, the flow is broken.

Your phone model

Xiaomi Mi 9

Operating system version

Android 14

Application version and app store

Element X Nightly (0.4.17)

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

Yes

@jmartinesp jmartinesp added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jul 12, 2024
@manuroe
Copy link
Member

manuroe commented Jul 23, 2024

Status when testing on 2024-07-23 nightly:

  • New rooms appear at the top of list as expected 🥳
  • The room preview screen can still be displayed after the room creation 😢 . I got this bug 33% of the time.

@manuroe
Copy link
Member

manuroe commented Jul 24, 2024

@ganfra was not able to reproduce it on 0.4.16. The regression happened between 0.4.16 and 0.5.0.

@ganfra
Copy link
Member

ganfra commented Jul 24, 2024

Ok so after some digging, the steps are :

  • we create the room
  • we wait for the room to appear in the RoomList
  • we try to get a room from the associated RoomListItem => we got an exception from rust sdk
    RoomListException$InitializingTimeline: error=Room !DKIcUGPMMbrsaYEPYC:matrix.org` not found``
  • It never recovers from that as we are expecting to have a full room at this point

@manuroe manuroe added the A-SSS Regression or bug observed when using Simplified Sliding Sync label Aug 2, 2024
@jmartinesp
Copy link
Member Author

I can't reproduce the issue anymore. @ganfra do you know a good way to make it easy to reproduce?

@manuroe
Copy link
Member

manuroe commented Sep 6, 2024

I tested it on the today nightly. The room preview screen appears every time I create a room on matrix.org, even for the first created room. I linked a rageshake to this issue in case it helps.

@manuroe
Copy link
Member

manuroe commented Sep 11, 2024

Project management trick: I moved this issue from the SSS project tasklist to the release blockers tasklist. Now, it is less related to SSS but more a global issue.

@jmartinesp
Copy link
Member Author

jmartinesp commented Sep 12, 2024

This should be fixed by matrix-org/matrix-rust-sdk#3979 once we build a new SDK version and add the new API call to wait until the room is synced.

@bmarty
Copy link
Member

bmarty commented Sep 16, 2024

Let's close the issue and open it again if it does not work as expected.

@bmarty bmarty closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SSS Regression or bug observed when using Simplified Sliding Sync T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

4 participants