Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's not at all clear that the "Share my location" button is a button #1486

Closed
ara4n opened this issue Aug 11, 2023 · 2 comments · Fixed by #2474
Closed

It's not at all clear that the "Share my location" button is a button #1486

ara4n opened this issue Aug 11, 2023 · 2 comments · Fixed by #2474
Assignees
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design

Comments

@ara4n
Copy link
Member

ara4n commented Aug 11, 2023

Steps to reproduce

  1. Select "location" from the (+) button on the composer.
  2. A popup card shows you the map with your location indicated with a (massive) pin-inside-a-pin. (sidenote: this feels way too big, and hides way too much surrounding map data; for instance, right now I can't even read the name of the street i'm on because the huge circle covers it. it feels like we have visibility-impaired mode enabled)
  3. Look around for a button to press to share your location.
  4. Notice there's a "Share my location" text at the bottom of the card. It looks a bit like a legend describing what the big pin means.
  5. Look around some more
  6. Realise that this text is actually a button you're meant to press in order to perform the share.

Outcome

What did you expect?

I expected there to be some hint that the "Share this location" text at the bottom is actually a button you're meant to interact with, rather than a legend or some other informative text:

image

That could be via a green 'action' highlight of some kind, or making it look like a button (by putting it on a lozenge or whatever), or some other affordance. But right now there ain't no affordance.

What happened instead?

This is the 3rd time or so i've tried to share my location, and found myself flummoxed by the UI.

Your phone model

No response

Operating system version

No response

Application version

340

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Aug 11, 2023
@Velin92 Velin92 added X-Needs-Design S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 16, 2023
@amshakal
Copy link

amshakal commented Jan 9, 2024

We used the same component as the bottom sheet that is used in various places in the app to form the same connection. i believe it will become clearler that it is a button is we change the icon of the button from the location icon to a share icon, which is a commonly used pattern.

As far as the size of the location pin is concerned, I reduced it by .90%, anything smaller would make the proportions looks weird.
Screenshot 2024-01-09 at 5 05 25 pm

@Velin92
Copy link
Member

Velin92 commented Feb 16, 2024

We used the same component as the bottom sheet that is used in various places in the app to form the same connection. i believe it will become clearler that it is a button is we change the icon of the button from the location icon to a share icon, which is a commonly used pattern.

As far as the size of the location pin is concerned, I reduced it by .90%, anything smaller would make the proportions looks weird. Screenshot 2024-01-09 at 5 05 25 pm

Maybe would be better to use the default iOS share icon that we use elsewhere in the app? (just for iOS)
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants