Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replies to redactions don’t render sensibly #2396

Closed
ara4n opened this issue Jan 27, 2024 · 3 comments · Fixed by #2606
Closed

Replies to redactions don’t render sensibly #2396

ara4n opened this issue Jan 27, 2024 · 3 comments · Fixed by #2606
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design X-Needs-Product

Comments

@ara4n
Copy link
Member

ara4n commented Jan 27, 2024 •
edited
Loading

Steps to reproduce

  1. reply to a msg
  2. redact the original msg
  3. reply ends up looking like this:

image

Outcome

What did you expect?

redacted msgs are shown as “deleted message” or something rather than just showing blank, which makes it look like the reply has failed to load.

Your phone model

No response

Application version

508

Will you send logs?

No
@ara4n ara4n added the T-Defect label Jan 29, 2024
@frebib
Copy link

frebib commented Jan 30, 2024

EXA has a similar problem in that it renders an empty box given the same scenario
Screenshot_20240130-122343.png

@frebib frebib mentioned this issue Jan 30, 2024
Closed
@Velin92 Velin92 added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Timeline X-Needs-Design X-Needs-Product S-Minor Impairs non-critical functionality or suitable workarounds exist and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 2, 2024
@manuroe
Copy link
Member

manuroe commented Mar 26, 2024

@VolkerJunginger what text should we display for the deleted message?

@VolkerJunginger
Copy link

Same string as for deleted message.

@pixlwave pixlwave mentioned this issue Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design X-Needs-Product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ReplyView when its content has been redacted. element-hq/element-x-ios
5 participants
@frebib @ara4n @manuroe @Velin92 @VolkerJunginger