Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix: URIs should linkify #2802

Closed
marwing opened this issue May 7, 2024 · 0 comments · Fixed by #2828
Closed

matrix: URIs should linkify #2802

marwing opened this issue May 7, 2024 · 0 comments · Fixed by #2828
Labels
A-Permalink A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@marwing
Copy link

marwing commented May 7, 2024 •
edited
Loading

Steps to reproduce

  1. receive a message containing a matrix: URI
  2. try to use the URI as a permalink
  3. notice that it wasn't recognized as a matrix URI and only the domain is linkified

Outcome

What did you expect?

A clickable link (or pill) like for matrix.to links.
Element Web does this.

What happened instead?

IMG_3998

Your phone model

iPhone 13 mini / iPad Pro

Operating system version

iOS/iPadOS 17.4.1

Application version

1.6.4 (104)

Homeserver

Synapse 1.106.0 / Proxy 0.99.16

Will you send logs?

No
@pixlwave pixlwave mentioned this issue May 10, 2024
Merged
@stefanceriu stefanceriu added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Timeline A-Permalink and removed T-Defect labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Permalink A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support tapping Matrix URIs in messages. element-hq/element-x-ios
2 participants
@stefanceriu @marwing