-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP proxy connect error overly spammy and error level too high #16860
Labels
Comments
Does this actually happen for HTTP errors (status codes), or just timeouts/connection refused/DNS errors at the proxy etc? I would expect the latter (and for 503 that makes sense). Agreed we should treat this just like a TCP-level error. |
I think both. |
For reference, timeouts are much less spammy when no outbound proxy is used:
Or this is a cancelled connection:
Failed certificate verification:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I started proxying outbound requests via HTTP proxy (Squid), and now every remote server problem (HTTP error from peer, even transient HTTP errors, DNS error) is being logged with error level CRITICAL and includes a lengthy stack trace that doesn't help because the problem is caused by a federating peer.
See example log output below.
I would argue that remote servers errors should be logged at a much lower level, maybe INFO. And it should not contain any stack trace, as that's useless.
My proxy specific config (for docker-compose):
Steps to reproduce
Homeserver
matrix.schildbach.de
Synapse Version
1.99.0
Installation Method
Docker (matrixdotorg/synapse)
Database
postgres, single
Workers
Single process
Platform
Docker version 20.10.24+dfsg1, build 297e128
Configuration
No response
Relevant log output
Anything else that would be useful to know?
No response
The text was updated successfully, but these errors were encountered: