Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -E as shortcut for --exclude-pattern #75

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mpenning
Copy link

'-E' is a time-saver to avoid '--exclude-pattern' spam if you need to exclude matching on a lot of character patterns

This is a time-saver to avoid '--exclude-pattern' spam if you need to exclude matching on a lot of character patters
Copy link
Owner

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Can you add a sanity test to test_pssmain.py?

@mpenning
Copy link
Author

Can you add a sanity test to test_pssmain.py?

I just did... I expanded one of the existing test methods... please see commit d380e2e

Copy link
Owner

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test; seems like it's failing -- you may need to reset self.of or do a separate test

psslib/pss.py Outdated
@@ -1,3 +1,4 @@

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done...

@mpenning mpenning requested a review from eliben August 18, 2023 04:33
@eliben
Copy link
Owner

eliben commented Aug 18, 2023

Please fix the failing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants