Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Timers instead of Tickers in pod_controller's ControlLoop #65

Open
justnoise opened this issue Apr 15, 2020 · 0 comments
Open

Use Timers instead of Tickers in pod_controller's ControlLoop #65

justnoise opened this issue Apr 15, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@justnoise
Copy link
Contributor

justnoise commented Apr 15, 2020

The control loop for the PodController has a lot of cases with multiple tickers that can fire. Some of the ticker case statements could take seconds to run under very heavy loads and there are two tickers that run frequently (controlTicker and statusTicker) If one of the cases blocks is slow to run, that case could run repeatedly, starving other cases from running. That would be bad.

Lets switch to using Timers instead of tickers and reset the timer at the end of each case. For a sample of using Timers instead of Tickers, check virtual-kubelet's NodeController.controlLoop

@justnoise justnoise added the enhancement New feature or request label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant