Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent breakage with magic constants #102

Closed
michaelcandido opened this issue Jun 15, 2013 · 3 comments
Closed

Indent breakage with magic constants #102

michaelcandido opened this issue Jun 15, 2013 · 3 comments
Labels
Milestone

Comments

@michaelcandido
Copy link

Here is a natural example.

<?php

$x = some_function(__FILE__) . '';
                            $broken = true;

?>

But the assignment is not necessary.

<?php

some_function(__FILE__) . '';
                        $broken = true;

?>

Operators other than concatenation also produce it.

<?php

some_function(__FILE__) + 1;
                        $broken = true;

?>

Seems to be caused by the pattern of "f(MAGIC) infix_operator arg;"

@michaelcandido
Copy link
Author

PHP mode 1.10 of 2013-06-09

@ejmr
Copy link
Collaborator

ejmr commented Jun 16, 2013

Thank you for the bug report. I am able to replicate the problem so I will try to fix it soon, although realistically that might take a week due to other things I have going on at the moment.

@ejmr
Copy link
Collaborator

ejmr commented Aug 26, 2013

Fixed by commit a5fd4b5 but please see the commit message. The patch fixes the specific problem of the bug report but there may still be related corner-case problems we haven't seen yet.

@ejmr ejmr closed this as completed Aug 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants