Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{{rootURL}} changed to {{this.rootURL}} #100

Closed
vlascik opened this issue Jan 12, 2020 · 2 comments
Closed

{{rootURL}} changed to {{this.rootURL}} #100

vlascik opened this issue Jan 12, 2020 · 2 comments

Comments

@vlascik
Copy link

vlascik commented Jan 12, 2020

Before:

    {{#link-to "index" class="navbar-brand"}}<img src="{{rootURL}}images/logo3.png">{{/link-to}}
  </div>

After:

{{#link-to "index" class="navbar-brand"}}<img src="{{this.rootURL}}images/logo3.png">{{/link-to}}
  </div>

Current github master (3df3c19) + current master of telemetry-helpers (as the currently released version breaks on Windows)

@NullVoxPopuli
Copy link
Collaborator

Where is rootURL defined?

@vlascik
Copy link
Author

vlascik commented Jan 13, 2020

I think it used to be some sort of global variable or a helper, but it seems that doesn't work anymore, and the new router helpers (emberjs/rfcs#391) are not implemented yet. I'll close this.

@vlascik vlascik closed this as completed Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants