Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor version bump, please. #36

Closed
bjornstar opened this issue May 14, 2015 · 1 comment
Closed

Minor version bump, please. #36

bjornstar opened this issue May 14, 2015 · 1 comment

Comments

@bjornstar
Copy link

When you update dependencies with major version bumps, the least you can do is bump your minor version. That way you're not breaking the builds of people who only allow patch level changes.

chai 1.10 to 2.3.0 is a major version bump
mocha 2.1.0 to 2.2.4 is a minor version bump
ember-test-helpers 0.4.3 to 0.4.4 had a painful oversight

@dgeb
Copy link
Member

dgeb commented May 14, 2015

Sorry about this.

I've deleted v0.6.3 of ember-mocha from ember-mocha-builds.

I've pushed v0.7.0 of both ember-mocha and ember-cli-mocha.

@dgeb dgeb closed this as completed May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants