You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
upon updating ember-test-helpers, I have test code that resets the app hit the app instance willDestroy method, which errors on internalPendingRequests.clearPendingRequests() because internalPendingRequests is the (nonzero) integer result of calling the pendingRequests method.
Here's where the pendingRequests method is chained on the require that prevents accessing the other methods:
likewise the off calls are passing undefined since internalPendingRequests is an integer and not a module
If you look at the deleted code in #1047 it was not chaining pendingRequests on the old require('ember-testing/lib/test/pending_requests') which allowed accessing the different methods from that module.
Is a PR welcome here?
The text was updated successfully, but these errors were encountered:
upon updating ember-test-helpers, I have test code that resets the app hit the app instance
willDestroy
method, which errors oninternalPendingRequests.clearPendingRequests()
becauseinternalPendingRequests
is the (nonzero) integer result of calling thependingRequests
method.Here's where the pendingRequests method is chained on the require that prevents accessing the other methods:
ember-test-helpers/addon-test-support/@ember/test-helpers/settled.ts
Lines 30 to 31 in 9c6e884
error occurs here:
ember-test-helpers/addon-test-support/@ember/test-helpers/settled.ts
Line 59 in 9c6e884
likewise the
off
calls are passingundefined
sinceinternalPendingRequests
is an integer and not a moduleIf you look at the deleted code in #1047 it was not chaining
pendingRequests
on the oldrequire('ember-testing/lib/test/pending_requests')
which allowed accessing the different methods from that module.Is a PR welcome here?
The text was updated successfully, but these errors were encountered: