Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade registerHook and runHooks as official public APIs #1341

Closed
drewlee opened this issue Feb 23, 2023 · 5 comments
Closed

Upgrade registerHook and runHooks as official public APIs #1341

drewlee opened this issue Feb 23, 2023 · 5 comments

Comments

@drewlee
Copy link
Contributor

drewlee commented Feb 23, 2023 •
edited
Loading

The helper hooks API was initially implemented in a "semi-private" fashion as part of a pilot. However, it's been in use for several years now and has proven to be quite useful (leveraged by ember-a11y-testing) and stable. This warrants exporting them as official public APIs in @ember/test-helpers. It would also allow for exposing the TypeScript types associated with the helper hooks.

CC @scalvert and @rwjblue for awareness.
@drewlee
Copy link
Contributor Author

drewlee commented Feb 23, 2023 •
edited
Loading

I can help put up a PR for this if there are no major objections.

@chriskrycho
Copy link
Contributor

Please do! I think we are broadly aligned that this is good.

@scalvert
Copy link
Contributor

Thanks, @drewlee! Much appreciated!

@drewlee drewlee mentioned this issue Feb 27, 2023
Closed
@gitKrystan gitKrystan mentioned this issue Feb 27, 2023
Closed
@drewlee drewlee mentioned this issue Mar 1, 2023
Merged
@drewlee
Copy link
Contributor Author

drewlee commented Mar 3, 2023

Addressed via PR #1344

@NullVoxPopuli
Copy link
Sponsor Collaborator

These are now documented in API.md!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@scalvert @NullVoxPopuli @drewlee @chriskrycho