From b9115479e10fbd24849cba5c4a2cd002db894482 Mon Sep 17 00:00:00 2001 From: Robert Jackson Date: Sat, 16 Dec 2017 10:20:04 -0500 Subject: [PATCH 1/2] Fix comment around IE11 detection. It makes no sense, I know. But it definitely is correct. --- tests/helpers/browser-detect.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/helpers/browser-detect.js b/tests/helpers/browser-detect.js index 4b2bd4717..a8e28d55e 100644 --- a/tests/helpers/browser-detect.js +++ b/tests/helpers/browser-detect.js @@ -1,4 +1,4 @@ -// `window.ActiveXObject` returns undefined in IE11 (as well as non-IE browsers) +// `window.ActiveXObject` is "falsey" in IE11 (but not `undefined` or `false`) // `"ActiveXObject" in window` returns `true` in all IE versions // only IE11 will pass _both_ of these conditions export const isIE11 = !window.ActiveXObject && 'ActiveXObject' in window; From aa7232d02ac816d4e93e232b16038af6e45a09a2 Mon Sep 17 00:00:00 2001 From: Robert Jackson Date: Sat, 16 Dec 2017 10:20:52 -0500 Subject: [PATCH 2/2] Clarify MS Edge overrides for blur events. Only the `blurSteps `are different than the default. This makes that clearer. --- tests/unit/dom/blur-test.js | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/unit/dom/blur-test.js b/tests/unit/dom/blur-test.js index bc94917cc..92256c4c0 100644 --- a/tests/unit/dom/blur-test.js +++ b/tests/unit/dom/blur-test.js @@ -10,7 +10,6 @@ if (isIE11) { focusSteps = ['focusin', 'focus']; blurSteps = ['focusout', 'blur']; } else if (isEdge) { - focusSteps = ['focus', 'focusin']; blurSteps = ['focusout', 'blur']; }