From 61666483d6bf122a79f48b852afa24af230dbe81 Mon Sep 17 00:00:00 2001
From: Mohamed ELIDRISSI <67818913+elidrissidev@users.noreply.github.com>
Date: Thu, 4 May 2023 14:40:22 +0100
Subject: [PATCH 1/6] Fixed price expression SQL in layered navigation (#3227)
---
.../core/Mage/Catalog/Model/Resource/Layer/Filter/Price.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/code/core/Mage/Catalog/Model/Resource/Layer/Filter/Price.php b/app/code/core/Mage/Catalog/Model/Resource/Layer/Filter/Price.php
index a71e588497d..6390996e95a 100644
--- a/app/code/core/Mage/Catalog/Model/Resource/Layer/Filter/Price.php
+++ b/app/code/core/Mage/Catalog/Model/Resource/Layer/Filter/Price.php
@@ -309,7 +309,7 @@ public function loadPrices($filter, $limit, $offset = null, $lowerPrice = null,
if (!is_null($upperPrice)) {
$select->where("$priceExpression < " . $this->_getComparingValue($upperPrice, $filter));
}
- $select->order("$priceExpression ASC")->limit($limit, $offset);
+ $select->order(new Zend_Db_Expr("$priceExpression ASC"))->limit($limit, $offset);
return $this->_getReadAdapter()->fetchCol($select);
}
@@ -372,7 +372,7 @@ public function loadNextPrices($filter, $price, $rightIndex, $upperPrice = null)
if (!is_null($upperPrice)) {
$pricesSelect->where("$priceExpression < " . $this->_getComparingValue($upperPrice, $filter));
}
- $pricesSelect->order("$priceExpression DESC")->limit($rightIndex - $offset + 1, $offset - 1);
+ $pricesSelect->order(new Zend_Db_Expr("$priceExpression DESC"))->limit($rightIndex - $offset + 1, $offset - 1);
return array_reverse($this->_getReadAdapter()->fetchCol($pricesSelect));
}
From e56ab9012310ac7a18c3422d44b846bc4ec00377 Mon Sep 17 00:00:00 2001
From: Mohamed ELIDRISSI <67818913+elidrissidev@users.noreply.github.com>
Date: Sun, 7 May 2023 21:33:59 +0100
Subject: [PATCH 2/6] Fixed stock status update from SOAP API V2 (#1635)
---
.../Mage/CatalogInventory/Model/Stock/Item/Api/V2.php | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/app/code/core/Mage/CatalogInventory/Model/Stock/Item/Api/V2.php b/app/code/core/Mage/CatalogInventory/Model/Stock/Item/Api/V2.php
index c2361371878..d2d14d0ea59 100644
--- a/app/code/core/Mage/CatalogInventory/Model/Stock/Item/Api/V2.php
+++ b/app/code/core/Mage/CatalogInventory/Model/Stock/Item/Api/V2.php
@@ -35,14 +35,15 @@ public function update($productId, $data)
$idBySku = $product->getIdBySku($productId);
$productId = $idBySku ? $idBySku : $productId;
- $product->setStoreId($this->_getStoreId())
- ->load($productId);
+ /** @var Mage_CatalogInventory_Model_Stock_Item $stockItem */
+ $stockItem = Mage::getModel('cataloginventory/stock_item')
+ ->setStoreId($this->_getStoreId())
+ ->loadByProduct($productId);
- if (!$product->getId()) {
+ if (!$stockItem->getId()) {
$this->_fault('not_exists');
}
- $stockItem = $product->getStockItem();
$stockData = array_replace($stockItem->getData(), (array)$data);
$stockItem->setData($stockData);
From 73d4f483410486c96c5db1ad39f5eed84927423d Mon Sep 17 00:00:00 2001
From: Mohamed ELIDRISSI <67818913+elidrissidev@users.noreply.github.com>
Date: Tue, 9 May 2023 15:48:13 +0100
Subject: [PATCH 3/6] Load all child blocks in Adminhtml Head block (#3222)
---
app/design/adminhtml/default/default/template/page/head.phtml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/app/design/adminhtml/default/default/template/page/head.phtml b/app/design/adminhtml/default/default/template/page/head.phtml
index 1a00c95d647..84106be7256 100644
--- a/app/design/adminhtml/default/default/template/page/head.phtml
+++ b/app/design/adminhtml/default/default/template/page/head.phtml
@@ -50,5 +50,4 @@
helper('core/js')->getTranslatorScript() ?>
-getChildHtml('calendar'); ?>
-getChildHtml('optional_zip_countries'); ?>
+getChildHtml(); ?>
From a7413b8195ac77ee9087ed3770b2703daf86eb2c Mon Sep 17 00:00:00 2001
From: Fabrizio Balliano
Date: Tue, 9 May 2023 17:19:59 +0100
Subject: [PATCH 4/6] Removed double span element from HTML buttons (#3123)
---
.../base/default/template/catalog/msrp/popup.phtml | 2 +-
.../default/template/catalog/product/compare/list.phtml | 6 +++---
.../template/catalog/product/compare/sidebar.phtml | 2 +-
.../base/default/template/catalog/product/list.phtml | 4 ++--
.../base/default/template/catalog/product/new.phtml | 2 +-
.../default/template/catalog/product/view/addtocart.phtml | 2 +-
.../catalog/product/widget/new/content/new_grid.phtml | 2 +-
.../catalog/product/widget/new/content/new_list.phtml | 2 +-
.../default/template/catalogsearch/advanced/form.phtml | 2 +-
.../base/default/template/catalogsearch/form.mini.phtml | 2 +-
.../frontend/base/default/template/checkout/cart.phtml | 6 +++---
.../base/default/template/checkout/cart/coupon.phtml | 4 ++--
.../base/default/template/checkout/cart/crosssell.phtml | 2 +-
.../checkout/cart/item/configure/updatecart.phtml | 2 +-
.../base/default/template/checkout/cart/shipping.phtml | 4 ++--
.../base/default/template/checkout/cart/sidebar.phtml | 2 +-
.../template/checkout/multishipping/address/select.phtml | 2 +-
.../template/checkout/multishipping/addresses.phtml | 6 +++---
.../default/template/checkout/multishipping/billing.phtml | 2 +-
.../template/checkout/multishipping/overview.phtml | 2 +-
.../template/checkout/multishipping/shipping.phtml | 2 +-
.../default/template/checkout/multishipping/success.phtml | 2 +-
.../base/default/template/checkout/onepage/billing.phtml | 2 +-
.../base/default/template/checkout/onepage/link.phtml | 2 +-
.../base/default/template/checkout/onepage/login.phtml | 4 ++--
.../base/default/template/checkout/onepage/payment.phtml | 2 +-
.../default/template/checkout/onepage/review/button.phtml | 2 +-
.../base/default/template/checkout/onepage/shipping.phtml | 2 +-
.../template/checkout/onepage/shipping_method.phtml | 2 +-
.../frontend/base/default/template/checkout/success.phtml | 2 +-
.../frontend/base/default/template/contacts/form.phtml | 2 +-
.../frontend/base/default/template/customer/address.phtml | 2 +-
.../base/default/template/customer/address/book.phtml | 2 +-
.../base/default/template/customer/address/edit.phtml | 2 +-
.../base/default/template/customer/form/address.phtml | 2 +-
.../default/template/customer/form/changepassword.phtml | 2 +-
.../default/template/customer/form/confirmation.phtml | 2 +-
.../base/default/template/customer/form/edit.phtml | 2 +-
.../default/template/customer/form/forgotpassword.phtml | 2 +-
.../base/default/template/customer/form/login.phtml | 4 ++--
.../base/default/template/customer/form/mini.login.phtml | 2 +-
.../base/default/template/customer/form/newsletter.phtml | 2 +-
.../base/default/template/customer/form/register.phtml | 2 +-
.../template/customer/form/resetforgottenpassword.phtml | 2 +-
.../base/default/template/newsletter/subscribe.phtml | 2 +-
.../default/template/oauth/authorize/button-simple.phtml | 4 ++--
.../base/default/template/oauth/authorize/button.phtml | 6 ++++--
.../default/template/oauth/authorize/confirm-simple.phtml | 2 +-
.../default/template/oauth/authorize/form/login.phtml | 4 ++--
.../default/template/oauth/authorize/reject-simple.phtml | 2 +-
.../base/default/template/page/html/cookienotice.phtml | 2 +-
.../frontend/base/default/template/page/print.phtml | 2 +-
.../frontend/base/default/template/paygate/form/cc.phtml | 2 +-
.../base/default/template/paypal/express/review.phtml | 6 +++---
.../base/default/template/paypal/hss/review/button.phtml | 2 +-
.../template/persistent/checkout/onepage/billing.phtml | 2 +-
.../template/persistent/checkout/onepage/login.phtml | 8 ++++----
.../default/template/persistent/customer/form/login.phtml | 4 ++--
.../template/persistent/customer/form/register.phtml | 2 +-
.../default/template/reports/home_product_compared.phtml | 2 +-
.../default/template/reports/home_product_viewed.phtml | 2 +-
.../reports/widget/compared/content/compared_grid.phtml | 2 +-
.../reports/widget/compared/content/compared_list.phtml | 2 +-
.../reports/widget/viewed/content/viewed_grid.phtml | 2 +-
.../reports/widget/viewed/content/viewed_list.phtml | 2 +-
.../frontend/base/default/template/review/form.phtml | 2 +-
.../default/template/sales/billing/agreement/view.phtml | 2 +-
.../base/default/template/sales/billing/agreements.phtml | 2 +-
.../frontend/base/default/template/sales/guest/form.phtml | 2 +-
.../base/default/template/sales/order/details.phtml | 2 +-
.../default/template/sales/recurring/profile/view.phtml | 8 ++++----
.../base/default/template/sales/reorder/sidebar.phtml | 2 +-
.../base/default/template/sales/widget/guest/form.phtml | 2 +-
.../frontend/base/default/template/sendfriend/send.phtml | 4 ++--
.../base/default/template/shipping/tracking/popup.phtml | 4 ++--
.../base/default/template/tag/customer/view.phtml | 2 +-
.../base/default/template/wishlist/button/share.phtml | 2 +-
.../base/default/template/wishlist/button/tocart.phtml | 2 +-
.../base/default/template/wishlist/button/update.phtml | 2 +-
.../base/default/template/wishlist/item/column/cart.phtml | 2 +-
.../frontend/base/default/template/wishlist/shared.phtml | 4 ++--
.../frontend/base/default/template/wishlist/sharing.phtml | 2 +-
82 files changed, 110 insertions(+), 108 deletions(-)
diff --git a/app/design/frontend/base/default/template/catalog/msrp/popup.phtml b/app/design/frontend/base/default/template/catalog/msrp/popup.phtml
index 08e4ae35a12..b27281eb7b7 100644
--- a/app/design/frontend/base/default/template/catalog/msrp/popup.phtml
+++ b/app/design/frontend/base/default/template/catalog/msrp/popup.phtml
@@ -31,7 +31,7 @@
getChildHtml(); ?>
-
+
diff --git a/app/design/frontend/base/default/template/catalog/product/compare/list.phtml b/app/design/frontend/base/default/template/catalog/product/compare/list.phtml
index 8bab693fc52..003adc4b6c1 100644
--- a/app/design/frontend/base/default/template/catalog/product/compare/list.phtml
+++ b/app/design/frontend/base/default/template/catalog/product/compare/list.phtml
@@ -64,7 +64,7 @@ $_params = $this->escapeHtml(json_encode(['form_key' => $this->getFormKey()]));
'helper('catalog/product_compare')->getAddToCartUrlCustom($_item, false) ?>',
'',
'post')">
- __('Add to Cart') ?>
+ __('Add to Cart') ?>
__('Out of stock') ?>
@@ -135,7 +135,7 @@ $_params = $this->escapeHtml(json_encode(['form_key' => $this->getFormKey()]));
'helper('catalog/product_compare')->getAddToCartUrlCustom($_item, false) ?>',
'',
'post')">
- __('Add to Cart') ?>
+ __('Add to Cart') ?>
@@ -161,7 +161,7 @@ $_params = $this->escapeHtml(json_encode(['form_key' => $this->getFormKey()]));
-
+
__('Please wait...') ?>
diff --git a/app/design/frontend/base/default/template/catalog/product/compare/sidebar.phtml b/app/design/frontend/base/default/template/catalog/product/compare/sidebar.phtml
index 2d4526e2886..5fbc783c479 100644
--- a/app/design/frontend/base/default/template/catalog/product/compare/sidebar.phtml
+++ b/app/design/frontend/base/default/template/catalog/product/compare/sidebar.phtml
@@ -41,7 +41,7 @@ $_items = $_helper->getItemCount() > 0 ? $_helper->getItemCollection() : null;
__('You have no items to compare.') ?>
diff --git a/app/design/frontend/base/default/template/catalog/product/list.phtml b/app/design/frontend/base/default/template/catalog/product/list.phtml
index 6f739312a08..32acf3eb1dd 100644
--- a/app/design/frontend/base/default/template/catalog/product/list.phtml
+++ b/app/design/frontend/base/default/template/catalog/product/list.phtml
@@ -55,7 +55,7 @@
title="quoteEscape($this->__('Add to Cart')) ?>"
class="button btn-cart"
onclick="customFormSubmit('', '', 'post')">
-
__('Add to Cart') ?>
+ __('Add to Cart') ?>
@@ -120,7 +120,7 @@
title="quoteEscape($this->__('Add to Cart')) ?>"
class="button btn-cart"
onclick="customFormSubmit('', '', 'post')">
-
__('Add to Cart') ?>
+ __('Add to Cart') ?>
__('Out of stock') ?>
diff --git a/app/design/frontend/base/default/template/catalog/product/new.phtml b/app/design/frontend/base/default/template/catalog/product/new.phtml
index f786fce0227..3aad13afd3d 100644
--- a/app/design/frontend/base/default/template/catalog/product/new.phtml
+++ b/app/design/frontend/base/default/template/catalog/product/new.phtml
@@ -35,7 +35,7 @@
'getAddToCartUrlCustom($_product, [], false) ?>',
'',
'post')">
-
__('Add to Cart') ?>
+ __('Add to Cart') ?>
__('Out of stock') ?>
diff --git a/app/design/frontend/base/default/template/catalog/product/view/addtocart.phtml b/app/design/frontend/base/default/template/catalog/product/view/addtocart.phtml
index bc43f2fbdd2..b045a86c312 100644
--- a/app/design/frontend/base/default/template/catalog/product/view/addtocart.phtml
+++ b/app/design/frontend/base/default/template/catalog/product/view/addtocart.phtml
@@ -21,7 +21,7 @@
-
+
getChildHtml('', true, true) ?>
diff --git a/app/design/frontend/base/default/template/catalog/product/widget/new/content/new_grid.phtml b/app/design/frontend/base/default/template/catalog/product/widget/new/content/new_grid.phtml
index 735d783ac55..0d97243eb7a 100644
--- a/app/design/frontend/base/default/template/catalog/product/widget/new/content/new_grid.phtml
+++ b/app/design/frontend/base/default/template/catalog/product/widget/new/content/new_grid.phtml
@@ -40,7 +40,7 @@
'getAddToCartUrlCustom($_product, [], false) ?>',
'',
'post')">
- __('Add to Cart') ?>
+ __('Add to Cart') ?>
__('Out of stock') ?>
diff --git a/app/design/frontend/base/default/template/catalog/product/widget/new/content/new_list.phtml b/app/design/frontend/base/default/template/catalog/product/widget/new/content/new_list.phtml
index c5db8f99126..ad92b9caf14 100644
--- a/app/design/frontend/base/default/template/catalog/product/widget/new/content/new_list.phtml
+++ b/app/design/frontend/base/default/template/catalog/product/widget/new/content/new_list.phtml
@@ -38,7 +38,7 @@
'getAddToCartUrlCustom($_product, [], false) ?>',
'',
'post')">
- __('Add to Cart') ?>
+ __('Add to Cart') ?>
__('Out of stock') ?>
diff --git a/app/design/frontend/base/default/template/catalogsearch/advanced/form.phtml b/app/design/frontend/base/default/template/catalogsearch/advanced/form.phtml
index ac4a2b5ae14..5a00dfcdb90 100644
--- a/app/design/frontend/base/default/template/catalogsearch/advanced/form.phtml
+++ b/app/design/frontend/base/default/template/catalogsearch/advanced/form.phtml
@@ -75,7 +75,7 @@
-
+
getBlockHtml("formkey") ?>
diff --git a/app/design/frontend/base/default/template/checkout/multishipping/billing.phtml b/app/design/frontend/base/default/template/checkout/multishipping/billing.phtml
index 589f526749e..b306407a9bc 100644
--- a/app/design/frontend/base/default/template/checkout/multishipping/billing.phtml
+++ b/app/design/frontend/base/default/template/checkout/multishipping/billing.phtml
@@ -78,7 +78,7 @@
getBlockHtml('formkey') ?>
diff --git a/app/design/frontend/base/default/template/checkout/multishipping/overview.phtml b/app/design/frontend/base/default/template/checkout/multishipping/overview.phtml
index c4eef5c34ff..506932ab6ca 100644
--- a/app/design/frontend/base/default/template/checkout/multishipping/overview.phtml
+++ b/app/design/frontend/base/default/template/checkout/multishipping/overview.phtml
@@ -186,7 +186,7 @@
__('Grand Total:') ?> helper('checkout')->formatPrice($this->getTotal()) ?>
-
+
diff --git a/app/design/frontend/base/default/template/checkout/multishipping/shipping.phtml b/app/design/frontend/base/default/template/checkout/multishipping/shipping.phtml
index 97668f6e538..ff8bb728876 100644
--- a/app/design/frontend/base/default/template/checkout/multishipping/shipping.phtml
+++ b/app/design/frontend/base/default/template/checkout/multishipping/shipping.phtml
@@ -113,7 +113,7 @@
getChildHtml('checkout_billing_items') ?>
getBlockHtml('formkey') ?>
diff --git a/app/design/frontend/base/default/template/checkout/multishipping/success.phtml b/app/design/frontend/base/default/template/checkout/multishipping/success.phtml
index afc5a7bc10d..cd7591080e7 100644
--- a/app/design/frontend/base/default/template/checkout/multishipping/success.phtml
+++ b/app/design/frontend/base/default/template/checkout/multishipping/success.phtml
@@ -34,6 +34,6 @@
getChildHtml() ?>
-
+
diff --git a/app/design/frontend/base/default/template/checkout/onepage/billing.phtml b/app/design/frontend/base/default/template/checkout/onepage/billing.phtml
index 6a67bc7d305..8bd78fbcaa9 100644
--- a/app/design/frontend/base/default/template/checkout/onepage/billing.phtml
+++ b/app/design/frontend/base/default/template/checkout/onepage/billing.phtml
@@ -199,7 +199,7 @@
diff --git a/app/design/frontend/base/default/template/checkout/onepage/payment.phtml b/app/design/frontend/base/default/template/checkout/onepage/payment.phtml
index b01255acafc..c28d7c06dec 100644
--- a/app/design/frontend/base/default/template/checkout/onepage/payment.phtml
+++ b/app/design/frontend/base/default/template/checkout/onepage/payment.phtml
@@ -35,7 +35,7 @@