-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency checker is not checking versions correctly #19108
Comments
cc @ME-ON1 |
I would like to work on this :) |
i guess the priority is just to fix the version issue, but i would just flag that there are possibly some other issues with this script around handling of release dates <> last commit dates my longer term thought had been to move this to https://github.com/envoyproxy/pytooling and to add unit tests and type checking to it |
maintainer released a new version |
im thinking it should respect the version rather than release date tho - its valid to release 1.6.3 after 1.8.2 for example |
yes it can but what if like for example Also is |
we want to update to the latest (ie highest version number) which in this case 1.8.x |
sure then just have to compare the release version number and it will work |
i think this was fixed in #19111 |
Description
The dependency checker (that checks deps configured in
repository_locations.bzl
and opens github tickets) opens a new ticket when there is a newer versionIt seems however that the versions are not checked correctly, for example with #19106
The suggested version is both less than the ticket that it closed and the current version used in the repo
The text was updated successfully, but these errors were encountered: