Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency checker is not checking versions correctly #19108

Closed
phlax opened this issue Nov 26, 2021 · 9 comments
Closed

Dependency checker is not checking versions correctly #19108

phlax opened this issue Nov 26, 2021 · 9 comments
Assignees
Labels
bug dependencies Pull requests that update a dependency file

Comments

@phlax
Copy link
Member

phlax commented Nov 26, 2021

Description

The dependency checker (that checks deps configured in repository_locations.bzl and opens github tickets) opens a new ticket when there is a newer version

It seems however that the versions are not checked correctly, for example with #19106

The suggested version is both less than the ticket that it closed and the current version used in the repo

@phlax phlax added bug triage Issue requires triage dependencies Pull requests that update a dependency file and removed triage Issue requires triage labels Nov 26, 2021
@phlax
Copy link
Member Author

phlax commented Nov 26, 2021

cc @ME-ON1

@kfaseela
Copy link
Contributor

I would like to work on this :)

@phlax
Copy link
Member Author

phlax commented Nov 26, 2021

i guess the priority is just to fix the version issue, but i would just flag that there are possibly some other issues with this script around handling of release dates <> last commit dates

my longer term thought had been to move this to https://github.com/envoyproxy/pytooling and to add unit tests and type checking to it

@ME-ON1
Copy link
Contributor

ME-ON1 commented Nov 26, 2021

maintainer released a new version 1.6.2 yesterday and 1.8.2 was version released in October. So i think tool is working fine and maintainer did a mistake in naming the release version
here -> https://github.com/edenhill/librdkafka/releases

@phlax
Copy link
Member Author

phlax commented Nov 26, 2021

im thinking it should respect the version rather than release date tho - its valid to release 1.6.3 after 1.8.2 for example

@ME-ON1
Copy link
Contributor

ME-ON1 commented Nov 26, 2021

yes it can but what if like for example 1.6.2 is the latest package released and 1.8.2 being older as in this case. And we look for latest release version by this tool.

Also is 1.6.2 is the version we want to updating.

@phlax
Copy link
Member Author

phlax commented Nov 26, 2021

we want to update to the latest (ie highest version number) which in this case 1.8.x

@ME-ON1
Copy link
Contributor

ME-ON1 commented Nov 26, 2021

sure then just have to compare the release version number and it will work

@phlax
Copy link
Member Author

phlax commented Dec 3, 2021

i think this was fixed in #19111

@phlax phlax closed this as completed Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants