Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: measure GRO performance and enable it via config #19119

Open
danzh2010 opened this issue Nov 29, 2021 · 0 comments
Open

quic: measure GRO performance and enable it via config #19119

danzh2010 opened this issue Nov 29, 2021 · 0 comments

Comments

@danzh2010
Copy link
Contributor

UDP GRO is supposed to improve socket read performance on client side but currently our code performs very poorly in nighthawk client, by reading one packet per read while allocating 24k buffer. It will be worthwhile to invest the suitable traffic patten for GRO.
Meanwhile this feature is disabled in #19088 and it will be good to exposed it via a config knob after we know the suitable use case.

And there was a bug reported that the socket reading code allocating 24k buffer per read might lead to MSG_TRUNC and cause packets dropped occasionally. We should change the value to be 64k which is the max GRO receive buffer allowed by the kernel.

@danzh2010 danzh2010 added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Nov 29, 2021
@mattklein123 mattklein123 added area/perf area/quic area/udp help wanted Needs help! and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants