Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possibly update the conditions used for invalid redirect filter options #357

Closed
skriss opened this issue Sep 7, 2022 · 2 comments
Closed

possibly update the conditions used for invalid redirect filter options #357

skriss opened this issue Sep 7, 2022 · 2 comments
Labels
area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. help wanted Extra attention is needed kind/question Further information is requested
Milestone
Backlog

Comments

@skriss
Copy link
Contributor

skriss commented Sep 7, 2022

There's some ambiguity in the Gateway API spec as to what conditions should be used for various invalid options on the redirect filter -- the spec specifies a type that is not actually defined for HTTPRoutes. I think it's a typo in the spec and the PR below would fix it, but we'll see what the Gateway API maintainers think.

ref. #249 (comment)

ref. kubernetes-sigs/gateway-api#1382
@skriss skriss mentioned this issue Sep 7, 2022
Merged
@danehans danehans added area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. help wanted Extra attention is needed kind/question Further information is requested labels Sep 9, 2022
@danehans danehans added this to the Backlog milestone Sep 9, 2022
@danehans
Copy link
Contributor

danehans commented Sep 9, 2022

@skriss Added this to the backlog. Feel free to change the milestone as needed.

@skriss
Copy link
Contributor Author

skriss commented Oct 4, 2022

Closing, replaced by #494

@skriss skriss closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/translator Issues related to Gateway's translation service, e.g. translating Gateway APIs into the IR. help wanted Extra attention is needed kind/question Further information is requested
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@danehans @skriss