Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

535 status code filter overhaul #536

Merged
merged 52 commits into from
Apr 15, 2022
Merged

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Apr 12, 2022

closes #535
closes #537

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #536 (96fc6b2) into main (9515a5d) will increase coverage by 0.09%.
The diff coverage is 95.19%.

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   93.63%   93.73%   +0.09%     
==========================================
  Files          64       64              
  Lines        7970    11106    +3136     
==========================================
+ Hits         7463    10410    +2947     
- Misses        507      696     +189     
Impacted Files Coverage Δ
src/event_handlers/command.rs 0.00% <ø> (ø)
src/lib.rs 100.00% <ø> (ø)
src/response.rs 96.47% <50.00%> (-0.12%) ⬇️
src/extractor/container.rs 89.20% <77.77%> (-0.69%) ⬇️
src/scanner/requester.rs 97.90% <90.47%> (-0.32%) ⬇️
src/banner/container.rs 98.46% <100.00%> (-0.14%) ⬇️
src/config/container.rs 97.01% <100.00%> (+2.20%) ⬆️
src/config/tests.rs 100.00% <100.00%> (ø)
src/event_handlers/outputs.rs 95.77% <100.00%> (+0.95%) ⬆️
src/event_handlers/scans.rs 90.83% <100.00%> (-2.43%) ⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9515a5d...96fc6b2. Read the comment docs.

@epi052 epi052 merged commit 4c0d3c9 into main Apr 15, 2022
@epi052 epi052 deleted the 535-status-code-filter-overhaul branch April 15, 2022 10:39
@epi052
Copy link
Owner Author

epi052 commented Apr 15, 2022

@all-contributors please add @ThisLimn0 for bugs

@allcontributors
Copy link
Contributor

@epi052

I've put up a pull request to add @ThisLimn0! 🎉

@epi052
Copy link
Owner Author

epi052 commented Apr 15, 2022

https://github.com/all-contributors please add @0xdf223 for bugs and ideas

@epi052
Copy link
Owner Author

epi052 commented Apr 15, 2022

@all-contributors please add @0xdf223 for bugs and ideas

@allcontributors
Copy link
Contributor

@epi052

I've put up a pull request to add @0xdf223! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant