Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCSS maps for z-index #1136

Open
m0ksem opened this issue Sep 25, 2021 · 3 comments
Open

SCSS maps for z-index #1136

m0ksem opened this issue Sep 25, 2021 · 3 comments
Labels
d3: medium No cheats. Monsters a bit faster. good first issue Right issue if you're new to vuestic optimization Optimize code performance refactoring Prettify code without introducing new features v1: minor This might be helpful, but not really

Comments

@m0ksem
Copy link
Contributor

m0ksem commented Sep 25, 2021

We have a lot of z-index properties set. It would be nice to have some scss map and set all properties from there.

or it can be CSS variables like we have with border-radius: #1134

For example:

--va-z-index-icons: 1
--va-z-index-dropdown: 10
--va-z-index-modals: 100
@m0ksem m0ksem added team discussion Feedback wanted optimization Optimize code performance external Reported by external contributor and handled with priority labels Sep 25, 2021
@asvae
Copy link
Member

asvae commented Sep 25, 2021

Some unified declaration would definitely help.

@asvae asvae removed the external Reported by external contributor and handled with priority label Sep 25, 2021
@asvae
Copy link
Member

asvae commented Oct 28, 2021

1,2,3,4,5 - 20000 - 20010 - 20020

5 - modal
4 - dropdown

--z-index-1
--z-index-2

--z-index-modal: var(--z-index-1)

@m0ksem m0ksem mentioned this issue Nov 2, 2021
Closed
@m0ksem m0ksem added the good first issue Right issue if you're new to vuestic label Apr 7, 2022
@asvae
Copy link
Member

asvae commented Jul 18, 2022

Needs affirmation and champion, otherwise looks ready for implementation.

@asvae asvae added LOW PRIORITY refactoring Prettify code without introducing new features and removed team discussion Feedback wanted labels Jul 21, 2022
@m0ksem m0ksem added d3: medium No cheats. Monsters a bit faster. v1: minor This might be helpful, but not really labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
d3: medium No cheats. Monsters a bit faster. good first issue Right issue if you're new to vuestic optimization Optimize code performance refactoring Prettify code without introducing new features v1: minor This might be helpful, but not really
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvae @m0ksem