Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squared switch #1140

Open
m0ksem opened this issue Sep 27, 2021 · 5 comments
Open

Squared switch #1140

m0ksem opened this issue Sep 27, 2021 · 5 comments
Labels
d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. docs packages/docs good first issue Right issue if you're new to vuestic v2: nice to have This will make Vuestic feel better

Comments

@m0ksem
Copy link
Collaborator

m0ksem commented Sep 27, 2021

image
https://www.figma.com/file/2yH0KFiWds3q1B5NA5dELZ/vuestic-ui?node-id=9%3A34

Can we have a square prop for VaSwitch?
@m0ksem m0ksem added the good first issue Right issue if you're new to vuestic label Sep 27, 2021
@m0ksem
Copy link
Collaborator Author

m0ksem commented Sep 27, 2021

am / pm can be used as true / false lable here.

@asvae asvae added the team discussion Feedback wanted label Sep 27, 2021
@asvae
Copy link
Member

asvae commented Sep 27, 2021

Wouldn't call it remotely the same component.
Behavior is just too different.

I.e. for "inline select"

  • loading would look differently
  • array-value doesn't make much of a sense given value could be not boolean
  • additionally, "inline select" can take more than 2 values.

We can discuss that in a call.

@asvae
Copy link
Member

asvae commented Sep 28, 2021

We discussed and decided to keep this as a separate component, as, indeed, the cases significantly differ from switch.

@asvae asvae removed the team discussion Feedback wanted label Oct 18, 2021
@asvae asvae closed this as completed Nov 25, 2021
@asvae asvae reopened this Nov 25, 2021
@m0ksem m0ksem self-assigned this Apr 12, 2022
@m0ksem m0ksem removed their assignment May 5, 2022
@m0ksem
Copy link
Collaborator Author

m0ksem commented Jan 24, 2023 •
edited
Loading

Let's have --va-switch-radius css variable that will change radius of circle and switch wrapper.
image

Let's have a demo example of using this css variable.

@m0ksem
Copy link
Collaborator Author

m0ksem commented Jan 24, 2023

And we don't need different CSS variables for small and big switches:
image

@m0ksem m0ksem added docs packages/docs d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. v2: nice to have This will make Vuestic feel better labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. docs packages/docs good first issue Right issue if you're new to vuestic v2: nice to have This will make Vuestic feel better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvae @m0ksem