Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist/quagga.min.js file gone #27

Closed
Roko131 opened this issue Aug 29, 2019 · 6 comments
Closed

dist/quagga.min.js file gone #27

Roko131 opened this issue Aug 29, 2019 · 6 comments

Comments

@Roko131
Copy link

Roko131 commented Aug 29, 2019

Hi, I would like to use this project using the script tag as written in readme but the dist/quagga.min.js file is missing.

I am not familiar with NPM.

Maybe you have an updated version of the quagga.min.js I could use?

Thanks for continuing this project!

@ericblade
Copy link
Owner

Hello there! It doesn't really make sense to have the distribution files in the source repository, as npm is the preferred way of installing a working version, and having the distribution files in source makes for really cluttered change views.

Assuming you have node installed, you should be able to do npm install @ericblade/quagga2 from your application.. that section of the README might need a bit of an update, though. . . If you'd like to generate the files yourself from the repo, you can run npm run build which will generate the packages as well.

Either way should work, though I think we probably need to do some changes to README with regards to how to get it to work correctly in a modern browser using npm install . . . all of my projects are using webpack and such to install modules.. so .. yeah.. maybe some changes are needed.

@ericblade
Copy link
Owner

ericblade commented Aug 30, 2019

I just ran a quick check after doing npm install @ericblade/quagga2

<script src="./node_modules/@ericblade/quagga2/dist/quagga.min.js"></script>
correctly loads quagga into global space as Quagga

of course you'd still need to include that file with whatever you're serving

@Roko131
Copy link
Author

Roko131 commented Sep 1, 2019

Thanks! learned something new.

@Roko131 Roko131 closed this as completed Sep 1, 2019
@ericblade
Copy link
Owner

how did you resolve?

@Roko131
Copy link
Author

Roko131 commented Sep 1, 2019

As you suggested:
npm install @ericblade/quagga2- which created ./node_modules/@ericblade/quagga2/dist/quagga.min.js which I then copied to my project.

I only use the quagga.min.js in my project- none of the other files created by npm install @ericblade/quagga2
btw I don't use webpack- I use the asset pipeline

@ericblade
Copy link
Owner

ericblade commented Sep 1, 2019

cool :) you could do the same with a copy of the repo and npm run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants