Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should set numOfWorkers to 0 automatically when Blob isn't available #38

Closed
ericblade opened this issue Sep 17, 2019 · 0 comments
Closed

Comments

@ericblade
Copy link
Owner

ericblade commented Sep 17, 2019

In the present version of the code, numOfWorkers > 0 fails in node due to (at the very least) Blob not being available. While Node probably can support the workers system now (probably with some changes), it would need to be fairly significantly overhauled to use Buffer instead of Blob, and then that would create browser issues, so we'd need to shim some sort of Buffer/Blob compatibility thing, or just re-do the worker part.

THEREFORE, I believe we should have the code basically check if (typeof Blob) { config.numOfWorkers = 0 } instead of allowing you to attempt to use it where it can't work, and getting failures that don't make sense.

@ericblade ericblade changed the title Anyone have any idea where / what module inserts Blob into the namespace in node? Should set numOfWorkers to 0 automatically when Blob isn't available Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant