Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Remove Trailing Slash from hostname #29

Closed
Aternus opened this issue Jan 15, 2020 · 1 comment
Closed

Feature Request: Remove Trailing Slash from hostname #29

Aternus opened this issue Jan 15, 2020 · 1 comment
Labels

Comments

@Aternus
Copy link

Aternus commented Jan 15, 2020

It would be great to have a setting that when enabled removes the trailing slash from the hostname so that Window titles look pretty while switching tabs/windows.

While we're at it, removing the "www." part for hostnames will make it even more awesome.

I can help with writing the regexes for that if you'd like 🙏

@erichgoldman
Copy link
Owner

A given website at https://www.example.com and https://example.com are not necessarily the same website; while this is customary, it is not always the case. Users may not want to automatically strip www if they are doing testing (did my redirect rule trigger properly) or to prevent accidentally activating on the wrong website.

There are also implications in the update algorithm within the extension that would make this very complicated. You should be able to use a regex to match in KeePass, and if you are using another tool it likely can do something similar.

As for the trailing slash, there are also non cosmetic reasons to keep the trailing slash. For example, if you match on example.com it might also match on example.com.evil.com or google.com-evilsite.com. This is an explicit decision in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants