Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window/Tab title not updated properly #6

Closed
admirabilis opened this issue Sep 23, 2015 · 8 comments
Closed

Window/Tab title not updated properly #6

admirabilis opened this issue Sep 23, 2015 · 8 comments

Comments

@admirabilis
Copy link

Hello, Erich! Thank you for this great extension!

On many websites I have noticed that with this extension enabled, the window title many times is not updated properly. For example:

  • Visit: https://addons.mozilla.org/en-US/firefox/
  • Title: Add-ons for Firefox - addons.mozilla.org/ - Firefox
  • Click on "Adblock Plus" at the "Most Popular" sidebar
  • Title: Add-ons for Firefox - addons.mozilla.org/ - Firefox

Now disable the extension:

This is just a harmless example. But sometimes I search for something on my search engine, for example "Firefox 41", and then use the search engine's own form to query for another unrelated word (eg. "Chocolate Ice Cream"), but the title remains the old, so after switching tabs, when I want to find the tab with the search for "Chocolate Ice Cream", I have to look for the tab named "Firefox 41".

Thank you for your attention!

@erichgoldman
Copy link
Owner

Thank you for reporting your specific examples. I have replicated the Adblock plus issue and will debug. Can you please let me know which search engine and with what URLS, etc. (please open a new ticket so I can track the one separate - one ticket for each example makes it easier).

Based upon the JavaScript and other dynamic activity on page, this types of things can happen (See FAQ).

I will investigate these specific examples to see if I can detect why they are not working. In development I am looking at a technique which would do more updates that may address these types of issues, however, it adds to overhead and could slow down all pages, etc. I have concerns over decreasing performance, but if these issues come from something else I can fix then we will see what I can do.

@admirabilis
Copy link
Author

Thank you for your answer, I have created issue #7 for the search engine!

@admirabilis
Copy link
Author

This bug (together with #7) was happening on Firefox 40, but doesn't seem to happen on Nightly 44.0a1!

@erichgoldman
Copy link
Owner

Okay, I will continue to track this. I am going to put this hold on fix until release 44 is out, they may have addressed something in the underlying processing that addresses this. If not, I will re-evaluate the more resource intensive solution I have in an offline test environment. Thank you for your report.

@admirabilis
Copy link
Author

OK, thanks!

@stonecrusher
Copy link

As the problem still exists in Firefox 50.0, I wanted to add that the full URL, which is added to the title by this addon, in fact does change. Just the title coming from the website itself does not update. It will update when pressing F5.

@erichgoldman
Copy link
Owner

Since Mozilla is moving to the new add-on framework I will not be making further updates in this branch. I am learning the new framework and will release a new version on that framework. The good news is the plugin will hopefully be one package that works on FF, Chrome, and others. We will see if this problem persists in the new framework. Since the code operates differently we may have completely different issues.

@erichgoldman
Copy link
Owner

Hello @teresaejunior , I have released a new version for modern Firefox, can you please update and let me know if the problem still persists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants