Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing problem, duplicated URL (other addon involved) #9

Closed
e13bb4dac2 opened this issue Feb 12, 2016 · 5 comments
Closed

Printing problem, duplicated URL (other addon involved) #9

e13bb4dac2 opened this issue Feb 12, 2016 · 5 comments
Labels

Comments

@e13bb4dac2
Copy link

Hello, I have some printing problems from time to time. At last I figured out why, now I'm just missing the how :)

Print Edit 16.4 and
Add URL to Window Title 1.01 disabled
Firefox 44.0.2, Windows 10.

Address bar URL:
https://plex.tv/

Tab name/tooltip/title:
"Plex: Your media on all your devices" (same having all add-ons disabled)

1. Print Edit enabled

1.2 Tab name/tooltip/title:
Plex: "Your media on all your devices"

2. Print Edit print dialog title:
"Plex: Your media on all your devices - Mozilla Firefox" (this string is sent to the printer/print job name, " - Mozilla Firefox" is added to the actual tab name content)

3. Add URL to Window Title 1.01 enabled

3.1 Tab name/tooltip/title:
"Plex: Your media on all your devices - https://plex.tv/"

3.2 Print Edit print dialog title:
"Plex: Your media on all your devices - https://plex.tv/ - https://plex.tv/ - Mozilla Firefox"

When the base title content is very long, the duplicated (when unusually long) URL + " - Mozilla Firefox" makes a printout fail using Print Edit. No error from the printer, the windows print manager/queue just stalls and eventually clears. No options in Print Edit.

Example:

http://www.skatteverket.se/funktioner/kalenderarkiv/2016privat/14mars.5.3810a01c150939e893f14fd.html

end up as

2016 års kalender för privatpersoner | Skatteverket - http://www.skatteverket.se/funktioner/kalenderarkiv/2016privat/14mars.5.3810a01c150939e893f14fd.html - http://www.skatteverket.se/funktioner/kalenderarkiv/2016privat/14mars.5.3810a01c150939e893f14fd.ht

note the 2 last characters of .html and " - Mozilla Firefox" is missing (string len limit?). I can't print this page using Print Edit - but it does work using the basic native (ctrl+p) print dialog.

Solution; disable/don't use/talk to Print Edit?

Well, yes. But..

As expected (according to 2.), print Edit will add " - Mozilla Firefox". That's OK! What I can't figure out is why the URL is duplicated, having Add URL to Window Title 1.01 enabled? Is it all on Print Edit or is your (great) add-on somehow shooting twice? :)

Cheers

Edit: formatting error due to quotes wrecked the underline tag

@erichgoldman
Copy link
Owner

Hello,

Add URL to Window Title (AUtWT) checks for updates or changes on the page. This is necessary for single page applications and for named anchor links / hashes links (e.g., something.html#someref).

There is a check to see if the title already includes the URL. But if there is heavy JavaScript this can cause issues.

I am not sure what is meant by "Print Edit enabled" If I go to the File menu and then select Print or Print Preview on that website I am not getting a URL duplication. I think maybe there is an internationalization or language difference here. Can you post a series of screenshots or a gif video of a screencast so I can better understand which menus you are accessing. I was not able to replicate from the above.

I am testing on 44.0.1 I will test on 44.0.02 with a fresh install. I do not have Windows 10, so there may be an issue there.

The way that this addon works is by modifying the actual <title /> tag. The part where - Mozilla Firefox is added can also be edited, but that was not a stable API. Mozilla is moving to a similar style of plugins as used in Chrome, so I am not actively updating this version as this type of plugin may loose support. However, if I can replicate and fix I will issue an update.

Thanks for reporting this issue and for posting the review on the Mozilla Add-On site! Hopefully we can get this fixed.

@e13bb4dac2
Copy link
Author

Hello,

I'm sorry for not being clear (addon mention in subject only) about Print Edit! Here's the link to the Print Edit addon:
https://addons.mozilla.org/sv-SE/firefox/addon/print-edit/

edit: missed pasting the URL within the link (url)-tag :/

I'll post screenshots during the weekend

Thanks for looking into it

:)

edit2: My (very nice) review above was removed. Probably because I linked here

@erichgoldman
Copy link
Owner

Hello,

I download the source for the Print Edit! extension. I did a quick search and it looks like that extension also does manipulations of the title field. There is no real way for the two extensions to communicate. I will see if there is something that can be done that would detect this. However, I think for the time being you will have to disable Add URL to Window Title when you want to use this print functionality.

@e13bb4dac2
Copy link
Author

Thanks for input - I'll keep saving as pdf for now (whenever I need to edit a print) and attempt to contact the author of Print Edit and point him/her to this thread. With luck there's a simple fix for this issue from his end of things, perhaps best of all an option to skip changes to title data and/or set a max string length, alternatively parsing out title URLs altogether.

Thanks again!

Will update when/if sorted out in the near future

@e13bb4dac2
Copy link
Author

Here's a picture. I have also linked to this thread here:
https://addons.mozilla.org/en-US/firefox/addon/print-edit/reviews/779933/

au2wtpe

! For whatever it is worth:
Base title: "2016 års kalender för privatpersoner | Skatteverket"
Added URL: "2016 års kalender för privatpersoner | Skatteverket - http://www.skatteverket.se/funktioner/kalenderarkiv/2016privat/14mars.5.3810a01c150939e893f14fd.html"
Added browser name: "2016 års kalender för privatpersoner | Skatteverket - http://www.skatteverket.se/funktioner/kalenderarkiv/2016privat/14mars.5.3810a01c150939e893f14fd.html - Mozilla Firefox"
This seems to be max length but not sure where the print actually fail: "2016 års kalender för privatpersoner | Skatteverket - http://www.skatteverket.se/funktioner/kalenderarkiv/2016privat/14mars.5.3810a01c150939e893f14fd.html - http://www.skatteverket.se/funktioner/kalenderarkiv/2016privat/14mars.5.3810a01c150939e893f14fd.html - http://www.skatteverket.se/funktioner/kalenderarkiv/2016privat/14mars.5.3810a01c150939e893f14fd.ht"
Full duplicated title including ' - Mozilla Firefox' would be: "2016 års kalender för privatpersoner | Skatteverket - http://www.skatteverket.se/funktioner/kalenderarkiv/2016privat/14mars.5.3810a01c150939e893f14fd.html - http://www.skatteverket.se/funktioner/kalenderarkiv/2016privat/14mars.5.3810a01c150939e893f14fd.html - http://www.skatteverket.se/funktioner/kalenderarkiv/2016privat/14mars.5.3810a01c150939e893f14fd.htmt - Mozilla Firefox"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants