Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop "pip3 install pyh5md" #49

Open
junghans opened this issue May 5, 2021 · 4 comments · May be fixed by #51
Open

Drop "pip3 install pyh5md" #49

junghans opened this issue May 5, 2021 · 4 comments · May be fixed by #51
Assignees
@XzzX

Comments

@junghans
Copy link
Member

junghans commented May 5, 2021

I don't think we need pip3 install pyh5md anymore, so should we drop it?
@XzzX
Copy link
Member

XzzX commented May 5, 2021

pyh5md is used within the project. If we want to drop the bundled version we need it installed in the containers. If we do not want to drop our bundles version we can remove it here.

@junghans
Copy link
Member Author

junghans commented May 5, 2021 •
edited
Loading

Sorry, I meant it gets installed as distro package as well.

@XzzX
Copy link
Member

XzzX commented May 5, 2021

Ok, somehow it needs to get installed. ;)
I think the best way would be to not install python dependencies at all in the containers but rely on running pip3 install -r requirements.txt in espressopp CI. This would test if requirements.txt is up-to-date. :D

@junghans
Copy link
Member Author

junghans commented May 5, 2021

I like that!

@XzzX XzzX linked a pull request May 7, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XzzX XzzX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove pre-installed python packages and rely on requirements.txt espressopp/buildenv
2 participants
@junghans @XzzX