From 818561f43f5ae371a086927fb28fe6d3d104487b Mon Sep 17 00:00:00 2001 From: Benjamin Wang Date: Fri, 1 Sep 2023 14:25:34 +0100 Subject: [PATCH] test: move all auth related test cases into a separate test file Signed-off-by: Benjamin Wang --- tests/e2e/v3_curl_auth_test.go | 147 +++++++++++++++++++++++++++++++++ tests/e2e/v3_curl_test.go | 98 ---------------------- 2 files changed, 147 insertions(+), 98 deletions(-) create mode 100644 tests/e2e/v3_curl_auth_test.go diff --git a/tests/e2e/v3_curl_auth_test.go b/tests/e2e/v3_curl_auth_test.go new file mode 100644 index 00000000000..4e6b73c4a3f --- /dev/null +++ b/tests/e2e/v3_curl_auth_test.go @@ -0,0 +1,147 @@ +// Copyright 2023 The etcd Authors +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package e2e + +import ( + "context" + "encoding/json" + "fmt" + "math/rand" + "testing" + + "go.etcd.io/etcd/api/v3/authpb" + pb "go.etcd.io/etcd/api/v3/etcdserverpb" + "go.etcd.io/etcd/api/v3/v3rpc/rpctypes" + "go.etcd.io/etcd/client/pkg/v3/testutil" + "go.etcd.io/etcd/pkg/v3/expect" + "go.etcd.io/etcd/tests/v3/framework/e2e" +) + +func TestV3CurlAuth(t *testing.T) { + testCtl(t, testV3CurlAuth) +} +func TestV3CurlAuthClientTLSCertAuth(t *testing.T) { + testCtl(t, testV3CurlAuth, withCfg(*e2e.NewConfigClientTLSCertAuthWithNoCN())) +} + +func testV3CurlAuth(cx ctlCtx) { + usernames := []string{"root", "nonroot", "nooption"} + pwds := []string{"toor", "pass", "pass"} + options := []*authpb.UserAddOptions{{NoPassword: false}, {NoPassword: false}, nil} + + // create users + for i := 0; i < len(usernames); i++ { + user, err := json.Marshal(&pb.AuthUserAddRequest{Name: usernames[i], Password: pwds[i], Options: options[i]}) + testutil.AssertNil(cx.t, err) + + if err = e2e.CURLPost(cx.epc, e2e.CURLReq{ + Endpoint: "/v3/auth/user/add", + Value: string(user), + Expected: expect.ExpectedResponse{Value: "revision"}, + }); err != nil { + cx.t.Fatalf("testV3CurlAuth failed to add user %v (%v)", usernames[i], err) + } + } + + // create root role + rolereq, err := json.Marshal(&pb.AuthRoleAddRequest{Name: "root"}) + testutil.AssertNil(cx.t, err) + + if err = e2e.CURLPost(cx.epc, e2e.CURLReq{ + Endpoint: "/v3/auth/role/add", + Value: string(rolereq), + Expected: expect.ExpectedResponse{Value: "revision"}, + }); err != nil { + cx.t.Fatalf("testV3CurlAuth failed to create role (%v)", err) + } + + //grant root role + for i := 0; i < len(usernames); i++ { + grantroleroot, err := json.Marshal(&pb.AuthUserGrantRoleRequest{User: usernames[i], Role: "root"}) + testutil.AssertNil(cx.t, err) + + if err = e2e.CURLPost(cx.epc, e2e.CURLReq{ + Endpoint: "/v3/auth/user/grant", + Value: string(grantroleroot), + Expected: expect.ExpectedResponse{Value: "revision"}, + }); err != nil { + cx.t.Fatalf("testV3CurlAuth failed to grant role (%v)", err) + } + } + + // enable auth + if err = e2e.CURLPost(cx.epc, e2e.CURLReq{ + Endpoint: "/v3/auth/enable", + Value: "{}", + Expected: expect.ExpectedResponse{Value: "revision"}, + }); err != nil { + cx.t.Fatalf("testV3CurlAuth failed to enable auth (%v)", err) + } + + for i := 0; i < len(usernames); i++ { + // put "bar[i]" into "foo[i]" + putreq, err := json.Marshal(&pb.PutRequest{Key: []byte(fmt.Sprintf("foo%d", i)), Value: []byte(fmt.Sprintf("bar%d", i))}) + testutil.AssertNil(cx.t, err) + + // fail put no auth + if err = e2e.CURLPost(cx.epc, e2e.CURLReq{ + Endpoint: "/v3/kv/put", + Value: string(putreq), + Expected: expect.ExpectedResponse{Value: "error"}, + }); err != nil { + cx.t.Fatalf("testV3CurlAuth failed to put without token (%v)", err) + } + + // auth request + authreq, err := json.Marshal(&pb.AuthenticateRequest{Name: usernames[i], Password: pwds[i]}) + testutil.AssertNil(cx.t, err) + + var ( + authHeader string + cmdArgs []string + lineFunc = func(txt string) bool { return true } + ) + + cmdArgs = e2e.CURLPrefixArgsCluster(cx.epc.Cfg, cx.epc.Procs[rand.Intn(cx.epc.Cfg.ClusterSize)], "POST", e2e.CURLReq{ + Endpoint: "/v3/auth/authenticate", + Value: string(authreq), + }) + proc, err := e2e.SpawnCmd(cmdArgs, cx.envMap) + testutil.AssertNil(cx.t, err) + defer proc.Close() + + cURLRes, err := proc.ExpectFunc(context.Background(), lineFunc) + testutil.AssertNil(cx.t, err) + + authRes := make(map[string]interface{}) + testutil.AssertNil(cx.t, json.Unmarshal([]byte(cURLRes), &authRes)) + + token, ok := authRes[rpctypes.TokenFieldNameGRPC].(string) + if !ok { + cx.t.Fatalf("failed invalid token in authenticate response using user (%v)", usernames[i]) + } + + authHeader = "Authorization: " + token + // put with auth + if err = e2e.CURLPost(cx.epc, e2e.CURLReq{ + Endpoint: "/v3/kv/put", + Value: string(putreq), + Header: authHeader, + Expected: expect.ExpectedResponse{Value: "revision"}, + }); err != nil { + cx.t.Fatalf("testV3CurlAuth failed to auth put with user (%v) (%v)", usernames[i], err) + } + } +} diff --git a/tests/e2e/v3_curl_test.go b/tests/e2e/v3_curl_test.go index 1aa39e5082e..cc9b83a2f33 100644 --- a/tests/e2e/v3_curl_test.go +++ b/tests/e2e/v3_curl_test.go @@ -26,10 +26,7 @@ import ( "github.com/stretchr/testify/require" - "go.etcd.io/etcd/api/v3/authpb" pb "go.etcd.io/etcd/api/v3/etcdserverpb" - "go.etcd.io/etcd/api/v3/v3rpc/rpctypes" - "go.etcd.io/etcd/client/pkg/v3/testutil" "go.etcd.io/etcd/pkg/v3/expect" epb "go.etcd.io/etcd/server/v3/etcdserver/api/v3election/v3electionpb" "go.etcd.io/etcd/tests/v3/framework/e2e" @@ -43,17 +40,6 @@ func TestV3CurlWatch(t *testing.T) { } } -func TestV3CurlAuth(t *testing.T) { - for _, p := range apiPrefix { - testCtl(t, testV3CurlAuth, withApiPrefix(p)) - } -} -func TestV3CurlAuthClientTLSCertAuth(t *testing.T) { - for _, p := range apiPrefix { - testCtl(t, testV3CurlAuth, withApiPrefix(p), withCfg(*e2e.NewConfigClientTLSCertAuthWithNoCN())) - } -} - func testV3CurlWatch(cx ctlCtx) { // store "bar" into "foo" putreq, err := json.Marshal(&pb.PutRequest{Key: []byte("foo"), Value: []byte("bar")}) @@ -80,90 +66,6 @@ func testV3CurlWatch(cx ctlCtx) { require.ErrorContains(cx.t, err, "unexpected exit code") } -func testV3CurlAuth(cx ctlCtx) { - p := cx.apiPrefix - usernames := []string{"root", "nonroot", "nooption"} - pwds := []string{"toor", "pass", "pass"} - options := []*authpb.UserAddOptions{{NoPassword: false}, {NoPassword: false}, nil} - - // create users - for i := 0; i < len(usernames); i++ { - user, err := json.Marshal(&pb.AuthUserAddRequest{Name: usernames[i], Password: pwds[i], Options: options[i]}) - testutil.AssertNil(cx.t, err) - - if err = e2e.CURLPost(cx.epc, e2e.CURLReq{Endpoint: path.Join(p, "/auth/user/add"), Value: string(user), Expected: expect.ExpectedResponse{Value: "revision"}}); err != nil { - cx.t.Fatalf("failed testV3CurlAuth add user %v with curl (%v)", usernames[i], err) - } - } - - // create root role - rolereq, err := json.Marshal(&pb.AuthRoleAddRequest{Name: "root"}) - testutil.AssertNil(cx.t, err) - - if err = e2e.CURLPost(cx.epc, e2e.CURLReq{Endpoint: path.Join(p, "/auth/role/add"), Value: string(rolereq), Expected: expect.ExpectedResponse{Value: "revision"}}); err != nil { - cx.t.Fatalf("failed testV3CurlAuth create role with curl using prefix (%s) (%v)", p, err) - } - - //grant root role - for i := 0; i < len(usernames); i++ { - grantroleroot, err := json.Marshal(&pb.AuthUserGrantRoleRequest{User: usernames[i], Role: "root"}) - testutil.AssertNil(cx.t, err) - - if err = e2e.CURLPost(cx.epc, e2e.CURLReq{Endpoint: path.Join(p, "/auth/user/grant"), Value: string(grantroleroot), Expected: expect.ExpectedResponse{Value: "revision"}}); err != nil { - cx.t.Fatalf("failed testV3CurlAuth grant role with curl using prefix (%s) (%v)", p, err) - } - } - - // enable auth - if err = e2e.CURLPost(cx.epc, e2e.CURLReq{Endpoint: path.Join(p, "/auth/enable"), Value: "{}", Expected: expect.ExpectedResponse{Value: "revision"}}); err != nil { - cx.t.Fatalf("failed testV3CurlAuth enable auth with curl using prefix (%s) (%v)", p, err) - } - - for i := 0; i < len(usernames); i++ { - // put "bar[i]" into "foo[i]" - putreq, err := json.Marshal(&pb.PutRequest{Key: []byte(fmt.Sprintf("foo%d", i)), Value: []byte(fmt.Sprintf("bar%d", i))}) - testutil.AssertNil(cx.t, err) - - // fail put no auth - if err = e2e.CURLPost(cx.epc, e2e.CURLReq{Endpoint: path.Join(p, "/kv/put"), Value: string(putreq), Expected: expect.ExpectedResponse{Value: "error"}}); err != nil { - cx.t.Fatalf("failed testV3CurlAuth no auth put with curl using prefix (%s) (%v)", p, err) - } - - // auth request - authreq, err := json.Marshal(&pb.AuthenticateRequest{Name: usernames[i], Password: pwds[i]}) - testutil.AssertNil(cx.t, err) - - var ( - authHeader string - cmdArgs []string - lineFunc = func(txt string) bool { return true } - ) - - cmdArgs = e2e.CURLPrefixArgsCluster(cx.epc.Cfg, cx.epc.Procs[rand.Intn(cx.epc.Cfg.ClusterSize)], "POST", e2e.CURLReq{Endpoint: path.Join(p, "/auth/authenticate"), Value: string(authreq)}) - proc, err := e2e.SpawnCmd(cmdArgs, cx.envMap) - testutil.AssertNil(cx.t, err) - defer proc.Close() - - cURLRes, err := proc.ExpectFunc(context.Background(), lineFunc) - testutil.AssertNil(cx.t, err) - - authRes := make(map[string]interface{}) - testutil.AssertNil(cx.t, json.Unmarshal([]byte(cURLRes), &authRes)) - - token, ok := authRes[rpctypes.TokenFieldNameGRPC].(string) - if !ok { - cx.t.Fatalf("failed invalid token in authenticate response with curl using user (%v)", usernames[i]) - } - - authHeader = "Authorization: " + token - - // put with auth - if err = e2e.CURLPost(cx.epc, e2e.CURLReq{Endpoint: path.Join(p, "/kv/put"), Value: string(putreq), Header: authHeader, Expected: expect.ExpectedResponse{Value: "revision"}}); err != nil { - cx.t.Fatalf("failed testV3CurlAuth auth put with curl using prefix (%s) and user (%v) (%v)", p, usernames[i], err) - } - } -} - func TestV3CurlCampaignNoTLS(t *testing.T) { for _, p := range apiPrefix { testCtl(t, testV3CurlCampaign, withApiPrefix(p), withCfg(*e2e.NewConfigNoTLS()))