Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for improving etcd continuous integration #15951

Closed
17 of 19 tasks
jmhbnz opened this issue May 25, 2023 · 6 comments
Closed
17 of 19 tasks

Plan for improving etcd continuous integration #15951

jmhbnz opened this issue May 25, 2023 · 6 comments

Comments

@jmhbnz
Copy link
Member

jmhbnz commented May 25, 2023

What would you like to be added?

This is an umbrella issue to plan a short series of work that will complete a set of improvements to etcd continuous integration, with some particular focus on our arm64 self hosted infrastructure, along with some broader fixes.

This issue was motivated by recent discussion in #15927.

Below are the tasks identified, these will be created as individual issues:

Potential additional tasks:

  • Consider cleanup process for maintaining etcd arm64 github runner docker installations (need to verify if this will actually be a problem or not once Run arm64 tests in containers on self hosted runners #15927 merges.)
  • Consider scaling up arm64 runner capacity by installing additional runner instances on each machine (this would subsequently enable running arm64 tests on a per pull request basis instead of only nightly.)
  • Consider creating some form of documentation for etcd ci workflows, there are a lot of files under main now which can be hard to decipher.

Why is this needed?

Once the above work items are complete in relation to arm64 infrastructure we should be able to progress with tier 1 support for arm64, and in general be in a better position when it comes to our continuous integration.

@BobyMCbobs
Copy link

BobyMCbobs commented May 30, 2023

Had a chat with @jmhbnz, a future improvement may be to move from a Docker-based containerised arm64 job to running these within a cluster with autoscaling on Equinix Metal.
Something like Cluster-API + node autoscaler + actions-runner-controller.

This can be implemented after the current plan has made it through.

@jmhbnz
Copy link
Member Author

jmhbnz commented Jul 5, 2023

@serathius, @ahrtr can I propose we pin this issue? It's about to drop off page 1. I suspect there will be a few more tasks to come under this umbrella and I've found it useful to group ci/testing things under this.

@ahrtr ahrtr pinned this issue Jul 5, 2023
@ahrtr
Copy link
Member

ahrtr commented Jul 5, 2023

can I propose we pin this issue?

Done.

@dneary
Copy link

dneary commented Oct 27, 2023

Does adding actuated support close the "add runners" task?

@jmhbnz
Copy link
Member Author

jmhbnz commented Oct 27, 2023

Does adding actuated support close the "add runners" task?

It does! Updated, thanks :)

@wenjiaswe wenjiaswe unpinned this issue Nov 5, 2023
@wenjiaswe wenjiaswe pinned this issue Nov 5, 2023
@wenjiaswe wenjiaswe unpinned this issue Nov 5, 2023
@jmhbnz
Copy link
Member Author

jmhbnz commented Nov 9, 2023

Closing - the primary set of improvements originally scoped have been completed.

@jmhbnz jmhbnz closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants