Enable testifylint linter rules

[ivanvc]

What would you like to be added?

This issue formalizes @mmorel-35's work (thanks!) to enable the linter rules from the testifylint linter.

The completion track is as follows:

• bool-compare - fix: enable bool-compare rule from testifylint #18686, deprecate testutil/assert.go #18717
• compares - fix: enable compares and negative-positive rules from testifylint #18715
• empty - fix: enable empty and len rules from testifylint #18712
• error-is-as - fix: enable error-is-as rule from testifylint #18740
• error-nil - fix: enable error-nil rule from testifylint #18716
• expected-actual - fix: enable expected-actual rule from testifylint #18720
• float-compare
• formatter - fix: enable formatter rule from testifylint #18741
• go-require
• len - fix: enable empty and len rules from testifylint #18712
• negative-positive - fix: enable compares and negative-positive rules from testifylint #18715
• nil-compare - fix: enable nil-compare rule from testifylint #18689, deprecate testutil/assert.go #18717
• require-error

Why is this needed?

To improve the code quality.

[ghouscht]

Hey @ivanvc, do you need some help here? I could take on a few items on the list if you want me to. Just let me know which are the preferred ones.
Thank you

[ivanvc]

Hi @ghouscht, thanks for offering your help with this task. Although it's unassigned (because I can't assign it to people outside of the etcd-io organization if they haven't participated in the issue), @mmorel-35 is doing it.

Therefore, I'm going to redirect the question. @mmorel-35, is there anything that @ghouscht could do to help with this task? Thanks.

[mmorel-35]

We actually have two open PR for this linter so until they are merged you can start with the error-is-as or formatter with formatter.require-f-funcs option enabled. Keep your PR as draft until one of them is merged so the number of opened PR stay narrowed concerning testifylint.

You can configure it with https://golangci-lint.run/usage/linters/#testifylint

Golangci lint can not fix it with --fix. You can use testifylint with -fix to start fixing it then review the changes to see if everthing works correctly.

[ghouscht]

Thank you for the response @mmorel-35, I found some time today and opened two PRs for the error-is-as and formatter rules:

• fix: enable error-is-as rule from testifylint #18740
• fix: enable formatter rule from testifylint #18741

I also tagged you on the PRs (sorry for the spam 🙂).

[ivanvc]

/assign @mmorel-35 @ghouscht