Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1898: Precedence not specified for conflicting values #2247

Closed
ryanschneider opened this issue Aug 19, 2019 · 4 comments
Closed

EIP-1898: Precedence not specified for conflicting values #2247

ryanschneider opened this issue Aug 19, 2019 · 4 comments
Labels

Comments

@ryanschneider
Copy link
Contributor

As discussed here: ethereum/go-ethereum#19491 (comment) the current version of the EIP does not specify how clients should behave if an object with both blockNumber and blockHash fields is sent as the block specifier.

In my opinion we have 4 options:

I see four options:

  • Option 1: Block Number takes priority
  • Option 2: Block Hash takes priority
  • Option 3: If both blockNumber and blockHash are specified, return an error indicating these values are exclusive
  • Option 4: If both blockNumber and blockHash are specified, enforce that both values are correct, otherwise return an error (i.e. lookup by hash, and return an error if returned header.Number != blockNumber).

I'm open to feedback on any of these options, but myself would lean towards Option 3 or 4.

@charles-cooper
Copy link
Contributor

If I didn't include it in the spec, my mistake. My intention was to follow EIP 234, whatever it does.

@ryanschneider
Copy link
Contributor Author

FWIW EIP-234 makes the number and hash options mutually exclusive (so Option 3). I'm fine with that.

@github-actions
Copy link

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Nov 20, 2021
@github-actions
Copy link

github-actions bot commented Dec 4, 2021

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants