Wrong error location

[ghost]

Many places the error location is wrong and point to wrong char / symbol. I think most of the failing cases are affected.

let {b, b} = {}; report 4th char as the position of b, but that's is a whitespace, but point at {. The second b has also wrong pos reported

Other example

var x = a; const x = b;

([a]) => { const a = 0; }

E.g in this case it point to correct symbol, but the position is wrong.

let x = a; function x(){};

var x; let x;

([foo], [foo]) => {}

In this case the loc points at the generator pos and not the symbol

{ function *foo() {}; function *foo() {}; }

This case is messed up

[...0,a]=0

[evanw]

Thanks for the report. As best I can tell, this was a regression that was introduced in version 0.18.7. That release added support for TypeScript's using declarations which affects variable declarations, so that's likely the cause of the regression.

Edit: Specifically during the refactoring in 69a0c80, there's one spot where binding.Loc should have been replaced with loc instead of being left as binding.Loc.

[ghost]

Here are examples that doesn't relate to decl

foo[...x];

[...{a: 0} = c]

[evanw]

I have tried out all of the cases you mention in the esbuild playground. The links to each case are below.

These ones look wrong, and are a result of the regression I mentioned earlier:

• let {b, b} = {}; (link)
• ([a]) => { const a = 0; } (link)

These ones look correct to me:

• let x = a; function x(){}; (link)
• var x; let x; (link)
• ([foo], [foo]) => {} (link)
• { function *foo() {}; function *foo() {}; } (link)
• [...0,a]=0 (link)

Please let me know if there is additional information necessary to reproduce the problem for the ones that look correct to me.