Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ParseServeOptions as public API #834

Closed
osdevisnot opened this issue Feb 18, 2021 · 0 comments
Closed

Introduce ParseServeOptions as public API #834

osdevisnot opened this issue Feb 18, 2021 · 0 comments

Comments

@osdevisnot
Copy link
Contributor

with sorvor, I use ParseBuildOptions as it helps me reuse same argument parsing logic as esbuild cli itself. This is beneficial for end users since they can then swap sorvor with esbuild without changing the cli arguments if sorvor does not meet their expectations.

However, the argument parsing for serve mode, specifically --serve=8000 or --servedir= are not exposed through a public API.

Would you consider adding a new ParseServeOptions as a public API?

I imagine the usage would then be something like this:

var serveOptions = api.ParseServeOptions(osArgs...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant