-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save_images_to_db=false
not working
#723
Comments
Looks like this is a critical bug. I checked the code and this logic was removed during refactoring that was in 0.6.0 version. |
@pospielov Do you have any ETA for 1.0.0? |
I think we will release this or the next week. |
Hello All Thanks |
All files are stored in |
Describe the bug
I'm testing CompreFace with the provided Docker Compose distribution in the root directory and looks like the
save_images_to_db=false
option does not work.The trained faces are still saved to Postgres
img
table.Tested with
v0.6.1
tag and the latest master.Based on docker inspect the related configuration option passed correctly to
compreface-api
.Here's the original implementation: https://github.com/exadel-inc/CompreFace/pull/163/files#diff-d829967df73c63987fa6772e8f2e0e9b9374ad3df661a20e3931094b1726253fR80
Quickly searching through the code, I can't see the relevant logic in the current codebase, but I'm not a big Java guy. :)
To Reproduce
Steps to reproduce the behavior:
.env
file setsave_images_to_db=false
img
table, a new entry will be added and the size of the data in thecontent
column is the same as the uploaded image sizeExpected behavior
Do not save the image to the database when
save_images_to_db=false
The text was updated successfully, but these errors were encountered: