Fix examples/downloads/files/utf-8 한中日.txt

[Fishrock123]

@dougwilson can we please fix this? It produces changes on my system without me doing anything..

[dougwilson]

Fix it how? I have never seen anyone else have that issue. Perhaps it us a bug in whatever that GUI you are using? Do you have a recommendation that won't remove the necessary test?

[Fishrock123]

Also happens in my CLI

I'm pretty sure the path to that file is invalid on my system somehow.
(OS X 10.9.5)

[dougwilson]

Gotcha. I don't have OS X to try, but I think that files was actually contributed by a OS X user and I'm sure most PRs are from OS X users who haven't complained. Perhaps it's just the version of git you have installed? IDK, man :)

[Fishrock123]

git version 1.9.3 (Apple Git-50)

[dougwilson]

In the end, I can probably just delete that file in the next minor express version when I change express to use the content-disposition module.

[Fishrock123]

👍

[meteormatt]

Maybe this issue is created by me, I will check it later.

[dougwilson]

@Fishrock123 can you tell me if running this:

$ git config --global core.precomposeunicode true

and deleting and re-cloning the repo fixes the issue for you?

[andrewrk]

We had a similar issue over here: thejoshwolfe/yauzl#10

What it comes down to is:

• OS X file system is stupid, it can't be trusted with non-ascii characters.
• Don't have non-ascii filenames checked in to git.

[dougwilson]

@andrewrk :( I knew it was from HFS+ and how it forces a specific Unicode normalization. @Fishrock123 did you ever get a chance to try that setting?

[Fishrock123]

Not yet, will try today.

[Fishrock123]

@dougwilson that does not appear to have any effect.

[dougwilson]

OK. I just wanted to confirm :) I'm going to just remove that whole example or something.

[andrewrk]

In yauzl we solved it by adding a small mapping thing to the test framework: https://github.com/thejoshwolfe/yauzl/blob/2804fdaec5146c25222778a7d80981e9ccc4e705/test/test.js#L181

So, change the filename to ascii, but in your tests, add a small mapping thing that translates the ascii into the correct string with unicode. When you open the file, use the real path, but when you test against the filename, use the one post-mapping.

[dougwilson]

The file isn't actually used in tests, though I thought it was at first; it's just used as an example of res.download functionality.