Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of fsevent to 1.1.3 to support node9 #4003

Closed
raarts opened this issue Feb 9, 2018 · 2 comments
Closed

Bump version of fsevent to 1.1.3 to support node9 #4003

raarts opened this issue Feb 9, 2018 · 2 comments

Comments

@raarts
Copy link

raarts commented Feb 9, 2018

Is this a bug report?

Yes.

fsevents only put up a node-9 binary version for v1.1.3

Did you try recovering your dependencies?

Yes. No dice. But reverting to node 8 worked.

Which terms did you search for in User Guide?

n/a

Environment

  1. node -v: v9.5.0
  2. npm -v: 5.6.0
  3. yarn --version (if you use Yarn): 1.3.2
  4. npm ls react-scripts (if you haven’t ejected): └── react-scripts@1.1.0

Then, specify:

  1. Operating system: OSX High Sierra
  2. Browser and version (if relevant): n/a

Steps to Reproduce

Just run create-react-app myproject

Expected Behavior

no warnings about fsevents.

Actual Behavior

Warnings, see below.

Reproducible Demo

Rons-MBP:tmp raarts$ create-react-app myproject

Creating a new React app in /Users/raarts/tmp/myproject.

Installing packages. This might take a couple of minutes.
Installing react, react-dom, and react-scripts...

yarn add v1.3.2
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
[-/3] ⠈ waiting...
[2/3] ⠈ fsevents: https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.3/fse-v1.1.3-node-v59-darwin-x64.tar.gz
[3/3] ⠈ fsevents: GET https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.2/fse-v1.1.2-node-v59-darwin-x64.tar.gz
[-/3] ⠈ waiting...
warning Error running install script for optional dependency: "/Users/raarts/tmp/myproject/node_modules/fsevents: Command failed.\nExit code: 1\nCommand: node install\nArguments: \nDirectory: /Users/raarts/tmp/myproject/node_modules/fsevents\nOutput:\nnode-pre-gyp info it worked if it ends with ok\nnode-pre-gyp info using node-pre-gyp@0.6.39\nnode-pre-gyp info using node@9.5.0 | darwin | x64\nnode-pre-gyp info check checked for \"/Users/raarts/tmp/myproject/node_modules/fsevents/lib/binding/Release/node-v59-darwin-x64/fse.node\" (not found)\nnode-pre-gyp http GET https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.2/fse-v1.1.2-node-v59-darwin-x64.tar.gz\nnode-pre-gyp http 404 https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.2/fse-v1.1.2-node-v59-darwin-x64.tar.gz\nnode-pre-gyp ERR! Tried to download(404): https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.2/fse-v1.1.2-node-v59-darwin-x64.tar.gz \nnode-pre-gyp ERR! Pre-built binaries not found for fsevents@1.1.2 and node@9.5.0 (node-v59 ABI, unknown) (falling back to source compile with node-gyp) \nnode-pre-gyp http 404 status code downloading tarball https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.2/fse-v1.1.2-node-v59-darwin-x64.tar.gz \nnode-pre-gyp ERR! build error \nnode-pre-gyp ERR! stack Error: Failed to execute 'node-gyp clean' (Error: spawn node-gyp ENOENT)\nnode-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/Users/raarts/tmp/myproject/node_modules/node-pre-gyp/lib/util/compile.js:77:29)\nnode-pre-gyp ERR! stack     at ChildProcess.emit (events.js:160:13)\nnode-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_procesuccess Saved lockfile.
success Saved 914 new dependencies.
├─ abab@1.0.4
├─ abbrev@1.1.1
├─ accepts@1.3.4
@gaearon
Copy link
Contributor

gaearon commented Feb 9, 2018

Yeah we should fix this.

@gaearon
Copy link
Contributor

gaearon commented Feb 9, 2018

Fixed in #4006.

@gaearon gaearon closed this as completed Feb 9, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants