Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-cli): include type definitions to generated config files #14078

Merged
merged 3 commits into from
Apr 22, 2023
Merged

feat(jest-cli): include type definitions to generated config files #14078

merged 3 commits into from
Apr 22, 2023

Conversation

mrazauskas
Copy link
Contributor

Summary

Currently config files generated using jest --init do not include type definitions. This PR adds type definitions for both JS and TS generated config files.

Test plan

Modified test to snapshot the whole config file.

@netlify
Copy link

netlify bot commented Apr 22, 2023

👷 Deploy request for jestjs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0d0bc98

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@SimenB SimenB merged commit d91ab8e into jestjs:main Apr 22, 2023
@mrazauskas mrazauskas deleted the cli-include-type-definitions-to-generated-config-files branch April 22, 2023 07:52
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2023
@SimenB
Copy link
Member

SimenB commented Jul 4, 2023

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants