Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Watchman on windows #4018

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Fix Watchman on windows #4018

merged 1 commit into from
Jul 13, 2017

Conversation

patroza
Copy link
Contributor

@patroza patroza commented Jul 12, 2017

Watchman returns / separated paths, but jest-haste-map uses path.sep which on windows equals \.

Summary

Addresses the issue finding tests on Windows with the latest watchman and Jest.
As a follow-up to #3887

Watchman returns `/` separated paths, but `jest-haste-map` uses `path.sep` which on windows equals `\`.
@codecov-io
Copy link

Codecov Report

Merging #4018 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4018   +/-   ##
=======================================
  Coverage   60.28%   60.28%           
=======================================
  Files         196      196           
  Lines        6764     6764           
  Branches        6        6           
=======================================
  Hits         4078     4078           
  Misses       2683     2683           
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-haste-map/src/crawlers/watchman.js 90.74% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6c5c4...cb7ab23. Read the comment docs.

@cpojer cpojer merged commit e89355a into jestjs:master Jul 13, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
Watchman returns `/` separated paths, but `jest-haste-map` uses `path.sep` which on windows equals `\`.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants