Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize resolve #4325

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Conversation

tvald
Copy link
Contributor

@tvald tvald commented Aug 22, 2017

Summary

Related to #2925. Clean up resolve() logic. Provide useful names for variables and functions. Test that a directory exists before attempting to resolve files within it.

Introduces slight performance improvements by testing whether a directory exists before attempting to resolve (potentially 10+) paths within the directory. Also tidies up code to meet style guidelines and usefully name variables + methods.

Test plan

Passes all tests.

…tions. Test that a directory exists before attempting to resolve files within it.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@cpojer cpojer merged commit fbd0708 into jestjs:master Aug 22, 2017
@cpojer
Copy link
Member

cpojer commented Aug 22, 2017

Thank you for the cleanup, very nice!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants