Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jsdom to 11.4 #4919

Merged
merged 3 commits into from
Nov 20, 2017
Merged

Upgrade jsdom to 11.4 #4919

merged 3 commits into from
Nov 20, 2017

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 20, 2017

Summary
This updates JSDOM to a version which includes support for {request,cancel}AnimationFrame out of the box.

Test plan
I verified that the deleted test worked with the new code before deleting it.

@codecov-io
Copy link

codecov-io commented Nov 20, 2017

Codecov Report

Merging #4919 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4919      +/-   ##
==========================================
+ Coverage   59.98%   60.01%   +0.02%     
==========================================
  Files         198      198              
  Lines        6563     6555       -8     
  Branches        4        4              
==========================================
- Hits         3937     3934       -3     
+ Misses       2626     2621       -5
Impacted Files Coverage Δ
packages/jest-environment-jsdom/src/index.js 41.46% <ø> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9303ecf...0320fd2. Read the comment docs.

@cpojer cpojer merged commit 1b19586 into jestjs:master Nov 20, 2017
@cpojer
Copy link
Member

cpojer commented Nov 20, 2017

Nice work @SimenB, so happy you pushed on this.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants