Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong messages for nthCalledWith #6340

Merged
merged 5 commits into from
May 30, 2018
Merged

Conversation

chinesedfan
Copy link
Contributor

Summary

formatMismatchedCalls prints the last x(usually x = 1) calls messages, but is not suitable for nthCalledWith. Same with #6338.

Test plan

@chinesedfan
Copy link
Contributor Author

@SimenB The old branch was force-updated and the PR was closed automatically, so I recreate another one. No new tests are added, but I fixed the original snapshot.

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Math checks out

@codecov-io
Copy link

Codecov Report

Merging #6340 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6340   +/-   ##
=======================================
  Coverage   63.89%   63.89%           
=======================================
  Files         228      228           
  Lines        8705     8705           
  Branches        4        3    -1     
=======================================
  Hits         5562     5562           
  Misses       3142     3142           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c91d5...d9c950f. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants