Added method to get an iterator for all files in HasteFS #7010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubennorte
commented
Sep 20, 2018
| @@ -44,6 +44,10 @@ export default class HasteFS { | |||
| return Array.from(this._files.keys()); | |||
| } | |||
|
|
|||
| getFileIterator(): Iterator<string> { | |||
There was a problem hiding this comment.
@rafeca you'll be able to use this in Metro. It should be way faster if you just want to iterate over the files.
|
Changelog? 😀 |
SimenB
approved these changes
Sep 20, 2018
Codecov Report
@@ Coverage Diff @@
## master #7010 +/- ##
==========================================
+ Coverage 66.94% 66.95% +<.01%
==========================================
Files 250 250
Lines 10401 10404 +3
Branches 4 3 -1
==========================================
+ Hits 6963 6966 +3
Misses 3437 3437
Partials 1 1
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This method is faster if the consumer only want to traverse the files (no need to create a new array). It is especially relevant if the number of files in the map is large.
Test plan
Only flow typechecking. This file isn't unit tested, but the code is so simple it doesn't really need it. Manually tested in the terminal.
Edit: tested through jest-resolve-dependencies, where it's used now