Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalize rootDir and cwd to their realpath #7598

Merged
merged 3 commits into from
Jan 10, 2019
Merged

fix: normalize rootDir and cwd to their realpath #7598

merged 3 commits into from
Jan 10, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 10, 2019

Summary

See discussion in #7556.

Result:
image

Previous result:
image

Does anyone think this might mess up somehow?

Test plan

Not sure how to write a test for this.

@SimenB SimenB mentioned this pull request Jan 10, 2019
Merged
SimenB
SimenB commented Jan 10, 2019
View reviewed changes
packages/jest-config/src/normalize.js

try {
options.rootDir = realpath(options.rootDir);
} catch (e) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it threw on CI since we have some /root/path in tests, which got a permission error

thymikee
thymikee approved these changes Jan 10, 2019
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include comments in why news realpath there?

@codecov-io
Copy link

Codecov Report

Merging #7598 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7598      +/-   ##
==========================================
+ Coverage   68.01%   68.03%   +0.01%     
==========================================
  Files         248      248              
  Lines        9499     9503       +4     
  Branches        6        6              
==========================================
+ Hits         6461     6465       +4     
  Misses       3036     3036              
  Partials        2        2
Impacted Files Coverage Δ
packages/jest-config/src/normalize.js 83.2% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c226c...cf15c24. Read the comment docs.

@SimenB
Copy link
Member Author

SimenB commented Jan 10, 2019

Can we include comments in why news realpath there?

Done: cf15c24

@SimenB SimenB merged commit 50c3852 into jestjs:master Jan 10, 2019
@SimenB SimenB deleted the win-rootdir branch January 10, 2019 10:03
willsmythe added a commit to willsmythe/jest that referenced this pull request Jan 10, 2019
@willsmythe
Drop unnecessary VSTS_OVERWRITE_TEMP. See jestjs#7598
822d04a
willsmythe added a commit to willsmythe/jest that referenced this pull request Jan 10, 2019
@willsmythe
Drop unnecessary VSTS_OVERWRITE_TEMP and fix failing tests. See jestj…
07e8a65 
…s#7598
willsmythe added a commit to willsmythe/jest that referenced this pull request Jan 10, 2019
@willsmythe
Drop unnecessary VSTS_OVERWRITE_TEMP and fix failing tests. See jestj…
45a3e15 
…s#7598

Signed-off-by: Will Smythe <wismythe@microsoft.com>
willsmythe added a commit to willsmythe/jest that referenced this pull request Jan 10, 2019
@willsmythe
Drop unnecessary VSTS_OVERWRITE_TEMP and fix failing tests. See jestj…
ea7935f 
…s#7598
willsmythe added a commit to willsmythe/jest that referenced this pull request Jan 14, 2019
@willsmythe
Drop unnecessary VSTS_OVERWRITE_TEMP and fix failing tests. See jestj…
c41ae05 
…s#7598
willsmythe added a commit to willsmythe/jest that referenced this pull request Jan 14, 2019
@willsmythe
Drop unnecessary VSTS_OVERWRITE_TEMP and fix failing tests. See jestj…
30e1ce6 
…s#7598
@fetz-bot fetz-bot mentioned this pull request Jan 26, 2019
Closed
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@SimenB @captain-yossarian
fix: normalize rootDir and cwd to their realpath (jestjs#7598)
3eca7dd
@fetz-bot fetz-bot mentioned this pull request Jan 22, 2020
Closed
@fetz-bot fetz-bot mentioned this pull request May 5, 2020
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

@rubennorte rubennorte Awaiting requested review from rubennorte

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimenB @codecov-io @thymikee @facebook-github-bot