Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate jest-regex-util to Typescript #7822

Merged
merged 4 commits into from
Feb 6, 2019

Conversation

lorenzorapetti
Copy link
Contributor

Summary

Diff:

diff --git a/packages/jest-regex-util/build/index.js b/packages/jest-regex-util/build/index.js
index 310d6876b..f3611a56f 100644
--- a/packages/jest-regex-util/build/index.js
+++ b/packages/jest-regex-util/build/index.js
@@ -17,7 +17,6 @@ function _interopRequireDefault(obj) {
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- *
  */
 const escapePathForRegex = dir => {
   if (_path.default.sep === '\\') {
@@ -40,7 +39,7 @@ const replacePathSepForRegex = string => {
   if (_path.default.sep === '\\') {
     return string.replace(
       /(\/|(.)?\\(?![[\]{}()*+?.^$|\\]))/g,
-      (_match, p1, p2) => (p2 && p2 !== '\\' ? p2 + '\\\\' : '\\\\')
+      (_match, _, p2) => (p2 && p2 !== '\\' ? p2 + '\\\\' : '\\\\')
     );
   }

Test plan

Green CI

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

Could you update the changelog as well? 🙏

@codecov-io
Copy link

Codecov Report

Merging #7822 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7822      +/-   ##
==========================================
+ Coverage   66.19%   66.19%   +<.01%     
==========================================
  Files         240      239       -1     
  Lines        9051     9040      -11     
  Branches        6        6              
==========================================
- Hits         5991     5984       -7     
+ Misses       3058     3054       -4     
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c07df0...dd7d2c8. Read the comment docs.

@lorenzorapetti
Copy link
Contributor Author

Thanks again!

Could you update the changelog as well? 🙏

Updated!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants