Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare global prototype in JSDOMEnvironment to fix issue #8347 #8352

Merged
merged 4 commits into from
Apr 21, 2019

Conversation

lh0x00
Copy link
Contributor

@lh0x00 lh0x00 commented Apr 20, 2019

I have described an issue at #8347.
We know ignores were not emitted by Typescript creating declaration files (ref microsoft/TypeScript#20360) and we can't build in your Typescript project if not skip checking types in libraries using.

I re-declared global prototype in JSDOMEnvironment class. I checked in my project and build files.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Could you update the changelog? :)

packages/jest-environment-jsdom/src/index.ts Show resolved Hide resolved
packages/jest-environment-jsdom/src/index.ts Outdated Show resolved Hide resolved
@lh0x00
Copy link
Contributor Author

lh0x00 commented Apr 21, 2019

@SimenB I updated PR and changelog.

@codecov-io
Copy link

codecov-io commented Apr 21, 2019

Codecov Report

Merging #8352 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8352      +/-   ##
==========================================
+ Coverage   62.18%   62.18%   +<.01%     
==========================================
  Files         266      266              
  Lines       10704    10703       -1     
  Branches     2604     2604              
==========================================
  Hits         6656     6656              
+ Misses       3462     3461       -1     
  Partials      586      586
Impacted Files Coverage Δ
packages/jest-environment-jsdom/src/index.ts 37.77% <ø> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e06e8...edac719. Read the comment docs.

@SimenB SimenB requested a review from jeysal April 21, 2019 08:40
@lh0x00
Copy link
Contributor Author

lh0x00 commented Apr 21, 2019

@SimenB @jeysal Thank you very much for helping me clarify the problem!
I updated PR and it ready to merge!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants