Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix babel-plugin-jest-hoist: getting full list of whitelisted globals #8429

Merged
merged 2 commits into from
May 7, 2019

Conversation

IanSavchenko
Copy link
Contributor

@IanSavchenko IanSavchenko commented May 6, 2019

Ref #8427

Summary

As mentioned in #8427, Node v12 has changed the enumerability of global.process and global.Buffer, thus the list of allowed globals became much shorter. I believe, that suggested change will improve the testing experience because it provides more complete list of available globals that can be safely used in hoisted mocks.

Test plan

I ran the e2e test for this plugin and it was all green.

npx jest
 PASS  __tests__/typescript.test.ts
 PASS  __tests__/integrationAutomockOff.test.js
 PASS  __tests__/integration.test.js

Test Suites: 3 passed, 3 total
Tests:       12 passed, 12 total
Snapshots:   0 total
Time:        2.25s

P.S. I signed the CLA.

@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #8429 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8429   +/-   ##
=======================================
  Coverage   62.32%   62.32%           
=======================================
  Files         266      266           
  Lines       10733    10733           
  Branches     2614     2615    +1     
=======================================
  Hits         6689     6689           
  Misses       3461     3461           
  Partials      583      583
Impacted Files Coverage Δ
packages/babel-plugin-jest-hoist/src/index.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2eaf4b...f1590da. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit aca4861 into jestjs:master May 7, 2019
This was referenced Oct 10, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants