Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix variable name in custom-matcher-api code example #8582

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

tohjustin
Copy link
Contributor

@tohjustin tohjustin commented Jun 19, 2019

Summary

This PR fixes #8581.

Test plan

Tested changes made to the docs by:

  1. Building the Jest website locally (following commands outlined in CONTRIBUTING.md)
  2. Navigating to http://localhost:3001/docs/en/expect#thisutils
  3. Inspecting changes made to the code example

@codecov-io
Copy link

codecov-io commented Jun 19, 2019

Codecov Report

Merging #8582 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8582   +/-   ##
=======================================
  Coverage   63.24%   63.24%           
=======================================
  Files         272      272           
  Lines       11311    11311           
  Branches     2760     2760           
=======================================
  Hits         7154     7154           
  Misses       3540     3540           
  Partials      617      617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d9698...932335c. Read the comment docs.

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thymikee thymikee changed the title docs: Fix variable name in custom-matcher-api code example (#8581) docs: Fix variable name in custom-matcher-api code example Jun 19, 2019
@thymikee thymikee merged commit 8df321d into jestjs:master Jun 19, 2019
@tohjustin
Copy link
Contributor Author

Thanks for the quick review! 😅

@tohjustin tohjustin deleted the issue-#8581 branch June 19, 2019 05:36
This was referenced Oct 10, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined variable being referenced in custom-matchers-api section's code example
4 participants