Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove declaration maps #9822

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 16, 2020

Summary

They don't work anyways since we run prettier on Jest's built code, and they bloat the install size.

Test plan

🤷

Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

Codecov Report

Merging #9822 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9822   +/-   ##
=======================================
  Coverage   64.88%   64.88%           
=======================================
  Files         289      289           
  Lines       12229    12229           
  Branches     3028     3030    +2     
=======================================
  Hits         7935     7935           
  Misses       3654     3654           
  Partials      640      640           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c6fb1...ba82581. Read the comment docs.

@SimenB SimenB merged commit da63789 into jestjs:master Apr 16, 2020
@SimenB SimenB deleted the remove-declaration-map branch April 16, 2020 11:02
@yordis
Copy link
Contributor

yordis commented Apr 19, 2020

They don't work anyway since we run prettier on Jest's built code

Why would you do that? -_-

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants